Skip to content

Set default memory resources for the ZooKeeper quorum#2463

Open
delthas wants to merge 2 commits into
development/2.15from
improvement/ZENKO-5316/zookeeper-quorum-default-resources
Open

Set default memory resources for the ZooKeeper quorum#2463
delthas wants to merge 2 commits into
development/2.15from
improvement/ZENKO-5316/zookeeper-quorum-default-resources

Conversation

@delthas

@delthas delthas commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do, and why do we need it?

Bumps zenko-operator to v1.8.14 and sets defaults.zookeeperResources in solution/zenkoversion.yaml, alongside the existing defaults.kafkaResources. Without it the quorum pods run BestEffort and the zookeeper image sizes its JVM heap as a percentage of the host memory instead of the container limit (RD-1962 finding, confirmed fleet-wide on ~240 sosreports).

Which issue does this PR fix?

Fixes ZENKO-5316.

Special notes for your reviewers:

zenko-operator v1.8.14 (scality/zenko-operator#624) is what applies the field to the ZookeeperCluster; the bump commit lands before the field is set. Sizing rationale and fleet data: see the review thread.

Issue: ZENKO-5316

@bert-e

bert-e commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Jul 13, 2026
@bert-e

bert-e commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@delthas
delthas requested review from a team, SylvainSenechal and benzekrimaha July 13, 2026 15:09
Comment thread solution/zenkoversion.yaml Outdated
@francoisferrand

Copy link
Copy Markdown
Contributor

is this really the issue we had in production? If Zookeeper were actually "easting" the memory, it would have affected the system already (i.e. prevented others from using memory); or is there something else causing this to happen now ?

@delthas
delthas force-pushed the improvement/ZENKO-5316/zookeeper-quorum-default-resources branch from e2e9eb6 to 89a1365 Compare July 16, 2026 14:12
@delthas
delthas requested review from DarkIsDude and removed request for benzekrimaha July 16, 2026 14:14
@delthas

delthas commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Requested @DarkIsDude in place of Maha Benzekri, who is currently on PTO.

@delthas
delthas requested review from francoisferrand and maeldonn and removed request for DarkIsDude July 16, 2026 14:16
@francoisferrand

Copy link
Copy Markdown
Contributor

Where the problem comes from: zenko 2.13.9 swapped pravega/zookeeper:0.2.15 (stock fixed ~1 GB -Xmx) for the adobe 3.8.4 image whose zkEnv.sh sets -XX:InitialRAMPercentage=30 -XX:MaxRAMPercentage=70

this is the information which was missing! thanks!

delthas added 2 commits July 17, 2026 10:38
Brings support for the ZenkoVersion defaults.zookeeperResources field.

Issue: ZENKO-5316
Without these, the quorum pods run BestEffort and the zookeeper image
sizes its JVM heap as a percentage of the host memory instead of the
container limit. Requires the zenko-operator supporting
defaults.zookeeperResources.

Issue: ZENKO-5316
@delthas
delthas force-pushed the improvement/ZENKO-5316/zookeeper-quorum-default-resources branch from 89a1365 to a4ff9db Compare July 17, 2026 08:38
@delthas

delthas commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

The check-workflows failure on this PR is unrelated to its changes: softprops/action-gh-release v3.0.2 (published 2026-07-13, pulled in automatically via the floating @v3 tag in release.yaml) changed its GitHub API call sequence, which breaks the tests/workflows/release.spec.ts mocks on every PR based on development/2.14+. Tracked in ZENKO-5317, fix in #2464.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants