feat(physicaldrive): flag partitions with an IsPartition field#84
Merged
ezekiel-alexrod merged 1 commit intoJul 17, 2026
Merged
Conversation
TeddyAndrieux
left a comment
TeddyAndrieux
left a comment
Contributor
There was a problem hiding this comment.
IMHO both changes shouldn't be merged here see my comments
The RHEL8 getter returns partition rows (lsblk TYPE=part) alongside their parent disk. Callers previously had to re-derive partition-ness from device names to tell them apart. Add an IsPartition field to the PhysicalDrive entity and set it in the RHEL8 getter (device.Type == "part"), so consumers can distinguish partitions from whole disks without string heuristics. Whole disks and partitions are both still returned; only the flag is new.
ezekiel-alexrod
force-pushed
the
fix/rhel8-getter-exclude-partitions-and-single-drive-force
branch
from
July 17, 2026 13:18
ae28251 to
bd8c985
Compare
ezekiel-alexrod
changed the title
ezekiel-alexrod
deleted the
fix/rhel8-getter-exclude-partitions-and-single-drive-force
branch
July 17, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add an
IsPartitionfield to thePhysicalDriveentity. The RHEL8 getter setsit (
device.Type == "part"). Whole disks and partitions are both still returnedby
PhysicalDrives; only the flag is new.Why
The getter returns partition rows (
lsblk TYPE=part) alongside their parentdisk. Callers previously had to re-derive partition-ness from device names to
tell them apart. The flag lets consumers distinguish partitions from whole disks
without string heuristics.
Tests
go test ./pkg/implementation/physicaldrivegetter/...-> PASSTestRHEL8_PhysicalDrives_Successnow assertsIsPartitionper entry.