fix(megaraid): remove cache policy prefixes on logical volume creation#85
Merged
ezekiel-alexrod merged 2 commits intoJul 17, 2026
Merged
Conversation
Match megaraidCreateCacheFlags now emitting bare storcli2 tokens.
TeddyAndrieux
approved these changes
Jul 17, 2026
ezekiel-alexrod
deleted the
bugfix/megaraid-remove-cache-prefixes-lv-creation
branch
July 17, 2026 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix logical volume creation on MegaRAID controllers: cache policy tokens
were emitted with the
set-command prefixes (rdpolicy=,wrcache=,iopolicy=), which theadd vdgrammar does not accept.Why
storcli2 add vdtakes cache policies as bare positional tokens, not askey=valuepairs. Passing the prefixed form made every creation fail:The
key=valueform is only valid on thesetpath (e.g.rdcache=,wrcache=), which is left untouched.What changed
megaraidCreateCacheFlagsnow returns the bare tokens from the mappers(
nora,wb,direct, ...) instead of prefixing them. The generatedcommand becomes:
Testing
go build ./...go test ./...(all green; updatedTestMegaraidCreateCacheFlagsexpectation to the bare-token form)