Support PathLike image and package file inputs#1123
Open
AlexanderWillner wants to merge 1 commit intoscanny:masterfrom
Open
Support PathLike image and package file inputs#1123AlexanderWillner wants to merge 1 commit intoscanny:masterfrom
AlexanderWillner wants to merge 1 commit intoscanny:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.PathLikeinputs inImage.from_file()os.PathLikeinputs inPart._blob_from_file()pathlib.Pathfile inputsWhy
python-pptxcurrently treats onlystrvalues as file paths in these helpers. Passingpathlib.Pathfalls through to the file-like branch and raises anAttributeErroron.seek/.readassumptions.Testing
PYTHONPATH=src python -m pytest tests/parts/test_image.py -qPYTHONPATH=src python -m pytest -o filterwarnings=ignore::pyparsing.warnings.PyparsingDeprecationWarning tests/opc/test_package.py tests/test_package.py -qslide.shapes.add_picture(Path(...), ...)with a JPEG fixture