fix: Quit panicking on named types over error#258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A panic breaks indexing for any module whose package graph contains a defined type whose underlying type is the built-in
errorinterface e.g.,type CustomErr error. The crash fires during implementation-relationship extraction.When scip-go walks a dependency's exported types and computes their method sets, the inherited
Errormethod on a user-defined wrapper overerrorsurfaces as a function whose enclosing package isnilbut whose receiver has been rebound to the user-defined nameCustomErr. The guard inGetSymbolOfObjectrecognized only the literal universe receiver, so the rebound form fell through to an unconditional panic.This change unconditionally skips any function with a
nilenclosing package during symbol lookup. The only such functions today are methods inherited from universe-block interfaces, which scip-go does not emit symbols for in any case, matching its existing behavior for directErrorcalls on plainerror-typed values.