Drop semanticdb prefix from indexer-internal symbol APIs#898
Closed
jupblb wants to merge 1 commit into
Closed
Conversation
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 3, 2026 10:42
c2402be to
6e8e91f
Compare
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 3, 2026 10:42
0d17945 to
4ec31f0
Compare
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 3, 2026 10:47
6e8e91f to
130802e
Compare
jupblb
marked this pull request as draft
June 3, 2026 10:50
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 3, 2026 10:52
4ec31f0 to
f6baf7f
Compare
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 3, 2026 15:24
130802e to
ffff8b2
Compare
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 3, 2026 15:24
f6baf7f to
8e2b403
Compare
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 3, 2026 15:34
ffff8b2 to
77d22d6
Compare
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 3, 2026 15:35
8e2b403 to
5671061
Compare
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 3, 2026 15:50
77d22d6 to
45e15d8
Compare
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 3, 2026 15:54
5671061 to
e8b5086
Compare
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 3, 2026 19:29
45e15d8 to
076c596
Compare
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 3, 2026 19:30
e8b5086 to
6e3adef
Compare
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 3, 2026 20:15
076c596 to
73b0ceb
Compare
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 3, 2026 20:16
6e3adef to
36d9f9d
Compare
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 4, 2026 07:12
73b0ceb to
04a458d
Compare
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 4, 2026 07:14
36d9f9d to
0f57615
Compare
jupblb
force-pushed
the
michal/drop-semanticdb-kotlin
branch
from
June 4, 2026 07:18
04a458d to
6663c59
Compare
Rename misleadingly-prefixed internal methods in semanticdb-javac and semanticdb-kotlinc (semanticdbSymbol -> scipSymbol, etc.) while keeping the public SemanticdbSymbols class name (still names the adopted grammar and is part of the published semanticdb-shared artifact).
jupblb
force-pushed
the
michal/scip-symbol-rename
branch
from
June 4, 2026 07:18
0f57615 to
16cabd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #897.
Renames misleading
semanticdb-prefixed identifiers in the Java/Kotlin indexer code now that we only emit SCIP:ScipSymbols.fromSemanticdbSymbol(String)→ScipSymbols.format(String)(Java + Kotlin)GlobalSymbolsCache.semanticdbSymbol/uncachedSemanticdbSymbol/semanticdbDescriptor→symbol/uncachedSymbol/descriptorSymbolsCache.ktequivalentsScipVisitorhelpers (semanticdbParentSymbols,semanticdbOverrides, etc.) lose the prefixsemanticdbSymbol→symbol; docstrings updated accordinglyThe shared
SemanticdbSymbolsutility class is kept — it encapsulates the symbol grammar SCIP adopted verbatim from SemanticDB, and it is part of the publishedcom.sourcegraph:semanticdb-javaartifact.Validated with
sbt --client checkAllandsbt --client unit/test.