Skip to content

Fix #36 Chunks forced by other mods or /forceload are removed every tick#51

Merged
scriptcoded merged 2 commits into
mainfrom
chore/fix#36
Apr 5, 2026
Merged

Fix #36 Chunks forced by other mods or /forceload are removed every tick#51
scriptcoded merged 2 commits into
mainfrom
chore/fix#36

Conversation

@Craemon

@Craemon Craemon commented Apr 4, 2026

Copy link
Copy Markdown
Collaborator

Fixed #36 based on the solution provided by @Smalldero. Had to change a few names etc because of Mojang Mappings...
Tested manually, issue seems to be resolved, could not find anything broken with the functionality of the mod.
Ran GameTest, all passed ofc.

@github-actions

github-actions Bot commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Release Preview

No release will be created when this pull request is merged.

@Craemon

Craemon commented Apr 4, 2026

Copy link
Copy Markdown
Collaborator Author

This new way of directly adding the chunk tickets should also open the door for #45
The current CustomTicketType just mimics the forceload ticket.
For player like loading one would probably just need to add another custom type with the same flags as the player loading a chunk has. This could then be used instead of the "CUSTOM_TICKETTYPE_FORCED" based on a gamerule.

@Craemon Craemon requested a review from scriptcoded April 4, 2026 22:02

@scriptcoded scriptcoded left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Clean and simple. Thanks @Craemon for the suggestion.

I'm trusting the gametests and you so let's go 😄

scriptcoded

This comment was marked as resolved.

@scriptcoded scriptcoded left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the back and forth. Merging with squash so that I don't block 😄

@scriptcoded scriptcoded merged commit f08ab01 into main Apr 5, 2026
4 checks passed
@scriptcoded scriptcoded deleted the chore/fix#36 branch April 5, 2026 09:26
@github-actions

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chunks forced by other mods or /forceload are removed every tick

2 participants