Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/align/read_align.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1084,10 +1084,11 @@ pub fn align_paired_read(

// Step 3: TooManyLoci check (post-dedup, matching STAR's ordering: multMapSelect → dedup → TooManyLoci).
if joint_pairs.len() > params.out_filter_multimap_nmax as usize {
let n_loci = joint_pairs.len();
return Ok((
Vec::new(),
pe_chimeric,
0,
n_loci,
Some(UnmappedReason::TooManyLoci),
));
}
Expand Down
3 changes: 1 addition & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1454,8 +1454,7 @@ fn align_reads_paired_end<W: AlignmentWriter + ?Sized>(
.collect();

if results.is_empty() {
// Both mates unmapped
stats.record_alignment(0, max_multimaps);
stats.record_alignment(n_for_mapq, max_multimaps);
stats.record_unmapped_reason(
unmapped_reason.unwrap_or(crate::stats::UnmappedReason::Other),
);
Expand Down
53 changes: 53 additions & 0 deletions src/stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,59 @@ mod tests {
assert_eq!(stats.unmapped_mismatches.load(Ordering::Relaxed), 1);
}

#[test]
fn test_too_many_loci_routed_and_totals_conserved() {
let stats = AlignmentStats::new();
let max_multimaps = 3;

stats.record_alignment(5, max_multimaps);
stats.record_unmapped_reason(UnmappedReason::TooManyLoci);

assert_eq!(stats.total_reads.load(Ordering::Relaxed), 1);
assert_eq!(stats.too_many_loci.load(Ordering::Relaxed), 1);
assert_eq!(stats.uniquely_mapped.load(Ordering::Relaxed), 0);
assert_eq!(stats.multi_mapped.load(Ordering::Relaxed), 0);
assert_eq!(stats.unmapped.load(Ordering::Relaxed), 0);
assert_eq!(stats.unmapped_other.load(Ordering::Relaxed), 0);
assert_eq!(stats.unmapped_short.load(Ordering::Relaxed), 0);
assert_eq!(stats.unmapped_mismatches.load(Ordering::Relaxed), 0);
}

#[test]
fn test_bucket_sum_conserved_with_too_many_loci() {
let stats = AlignmentStats::new();
let max_multimaps = 10;

for _ in 0..3 {
stats.record_alignment(1, max_multimaps);
}
for _ in 0..2 {
stats.record_alignment(5, max_multimaps);
}
for _ in 0..4 {
stats.record_alignment(0, max_multimaps);
stats.record_unmapped_reason(UnmappedReason::TooShort);
}
for _ in 0..2 {
stats.record_alignment(15, max_multimaps);
stats.record_unmapped_reason(UnmappedReason::TooManyLoci);
}

let total = stats.total_reads.load(Ordering::Relaxed);
let unique = stats.uniquely_mapped.load(Ordering::Relaxed);
let multi = stats.multi_mapped.load(Ordering::Relaxed);
let unmapped_short = stats.unmapped_short.load(Ordering::Relaxed);
let unmapped_other = stats.unmapped_other.load(Ordering::Relaxed);
let unmapped_mismatches = stats.unmapped_mismatches.load(Ordering::Relaxed);
let too_many_loci = stats.too_many_loci.load(Ordering::Relaxed);

assert_eq!(total, 11);
assert_eq!(too_many_loci, 2);
let bucket_sum =
unique + multi + unmapped_short + unmapped_other + unmapped_mismatches + too_many_loci;
assert_eq!(bucket_sum, total);
}

#[test]
fn test_splice_motif_aggregation() {
use crate::align::score::SpliceMotif;
Expand Down
Loading