chore: upstream cigar#57
Conversation
|
Oh yea so funny story. |
|
So you’re saying that we should get rid of |
|
I'm saying we should fix it. |
|
Is that a yes? Otherwise I don’t know what “fix” means, as I don’t know of anything that’s broken, just duplicate code that we can eliminate. |
flying-sheep
changed the title
| a.genome_end, | ||
| a.is_reverse, | ||
| &a.cigar, | ||
| //&a.cigar, |
There was a problem hiding this comment.
This (and another cmp farther down) are the only casualties: why is this here? Can a vector of cigar ops be “greater” or “less” than another? (other than length)
| genome_pos = acceptor; | ||
| } | ||
| CigarOp::Ins(_) | CigarOp::SoftClip(_) | CigarOp::HardClip(_) => {} | ||
| Kind::Insertion | Kind::SoftClip | Kind::HardClip | Kind::Pad => {} |
There was a problem hiding this comment.
I added Pad to all the “else” branches. Is that correct?
2 participants
TODO: why are we rolling our own
CigarOpinstead of usingnoodles::sam::alignment::record::cigar::Op?The only difference seems to be that that one has a
Padvariant that we don’t have.