testing: deduplicate integration stubs#473
Conversation
The Rust integration layer already provides these test-only symbols when cpp_integration_testing is enabled. Drop the duplicate C++ stubs from testing_unimplemented.cpp so static integration builds link against a single definition.
📝 WalkthroughWalkthroughThis pull request removes 8 exported stub function implementations from Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes a handful of duplicate C API stub definitions from src/testing_unimplemented.cpp so that, when cpp_integration_testing is enabled, static integration-test builds don’t encounter multiple-definition linker errors and instead link against the Rust-provided test-only stub symbols.
Changes:
- Deleted several
UNIMPLEMENTEDC++ stub exports that are already provided by the Rust integration-testing layer whencpp_integration_testingis enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CASS_EXPORT const CassValue* | ||
| cass_aggregate_meta_init_cond(const CassAggregateMeta* aggregate_meta) { | ||
| throw std::runtime_error("UNIMPLEMENTED cass_aggregate_meta_init_cond\n"); | ||
| } | ||
| CASS_EXPORT void cass_aggregate_meta_name(const CassAggregateMeta* aggregate_meta, | ||
| const char** name, size_t* name_length) { | ||
| throw std::runtime_error("UNIMPLEMENTED cass_aggregate_meta_name\n"); | ||
| } | ||
| CASS_EXPORT const CassDataType* |
This PR extracts one commit from #438 in order to merge it without further delay. It's authored by @dkropachev.
Original description:
Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests inMakefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.[ ] I added appropriateFixes:annotations to PR description.