fix(script_debug): emit DEBUG_SCRIPT frame for early-exit error paths#148
Open
febyeji wants to merge 1 commit intosedited:feature_script_debugfrom
Open
fix(script_debug): emit DEBUG_SCRIPT frame for early-exit error paths#148febyeji wants to merge 1 commit intosedited:feature_script_debugfrom
febyeji wants to merge 1 commit intosedited:feature_script_debugfrom
Conversation
GetOp failure, push-size overflow, and op-count overflow all returned before the DEBUG_SCRIPT call, leaving gaps in execution traces. Move the main call earlier (right after GetOp) and add a dedicated call for GetOp decode failure with OP_INVALIDOPCODE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three early-return paths in EvalScript exit before the DEBUG_SCRIPT call, so the debugger trace has no frame for the failing step:
SCRIPT_ERR_BAD_OPCODE— GetOp() decode failureSCRIPT_ERR_PUSH_SIZE— push data > 520 bytesSCRIPT_ERR_OP_COUNT— >201 non-push opcodesMove the main DEBUG_SCRIPT call to right after GetOp() succeeds, and add a dedicated call with OP_INVALIDOPCODE for decode failures.