Skip to content

Update README.md#34

Open
XavierAgostini wants to merge 1 commit into
masterfrom
xav/update-documentation
Open

Update README.md#34
XavierAgostini wants to merge 1 commit into
masterfrom
xav/update-documentation

Conversation

@XavierAgostini

Copy link
Copy Markdown
  • update installation instructions to explicitly use pod version
  • not having the version causes the app build to fail

- update installation instructions to explicitly use pod version
- not having the version causes the app build to fail
@srthurman

Copy link
Copy Markdown

cc @CarlosMecha for final approval before merging in.

@ladanazita

ladanazita commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

@XavierAgostini Why have customers pin a beta version here?

We should also have tests passing prior to merging.

Also, for documentation purposes, this is one of many places these instructions exist. Be sure to update:

  1. Partner portal instructions under components -> iOS
  2. Segment public documentation
  3. To update Cocoapods with instructions, we will have to wait until the next release occurs.

@XavierAgostini

Copy link
Copy Markdown
Author

@ladanazita the previous documentation had the incorrect dependency names. Also for some reason, the apps were all able to compile in our test apps and a customers app only when the dependency version was specified.

@ladanazita

Copy link
Copy Markdown
Contributor

Ah yes, I think this integration has been in beta due to the lack of a beta release process. The latest is 1.1.1-beta — should we update to point to that?

Have you debugged the failing tests?

@XavierAgostini

Copy link
Copy Markdown
Author

@ladanazita we tested this again today, and we were only able to get the integration to load by specifying the version and the beta flag. CI is saying the issue is:

Warning: Permanently added 'github.com,192.30.253.113' (RSA) to the list of known hosts.

Permission denied (publickey).

fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

git command i returned 128:

@briemcnally

Copy link
Copy Markdown
Contributor

@XavierAgostini is this still an issue we want to update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants