update streamType mapping to correctly reference livestream boolean value

[kdaswani]

Fox is seeing the Adobe streamType variable always set to “live” even when livestream = false (it should be “vod” in these cases). However, the Adobe STREAM_FORMAT variable is correctly set to “vod” when livestream = true. I have replicated the behavior and see that even when livestream = false, the streamType is labeled "live" in the network calls to Adobe.

In our integration code, we do basically the same mapping to each variable. The only difference is:

STREAM_FORMAT references bool isLivestream = [properties[@"livestream"] boolValue];
streamType references bool isLivestream = properties[@"livestream"];

@gpsamson confirmed that leaving out boolValue is causing our integration to not actually check the true/false value for streamType and therefore setting all events that have the livestream property to “live”. I have updated our integration so that streamType uses bool isLivestream = properties[@"livestream" boolValue]; instead. I have also updated the Tests to include the livestream property on playback and content events. All unit tests passed!

Unit test results:

[kdaswani]

@gpsamson I just completed local tests. I first validated that when I set @"livestream": @no (meaning it should be "vod"), the network request to Adobe maps s:stream:type to "live":

Then I updated my test app to target the branch in this PR and ran pod update. Since I already updated the podspec file in this branch, it successfully updated to 1.6.2:

And lastly, I built my app and triggered the same Video Playback Started event as before with @"livestream": @no. The result was a network request to Adobe that correctly maps s:stream:type to "vod":

Let me know your thoughts and if any other testing is needed! I can also ask Fox to target this branch and test before we release 😄

[kdaswani]

Shared branch with Fox for testing. Will update this PR with their results!

[kdaswani]

Hi @gpsamson! Fox tested this branch and confirmed that it fixed the issue for them. They are ready to integrate it whenever a new version of published! I think the new version will be 1.6.3? Let me know if you need anything else from me to get this merged and released. Thanks!

[kdaswani]

Hi @gpsamson any updates on this PR? Let me know if I can help with anything!

[kdaswani]

created new PR without changes to Example project: #55