Optimizely v2 compatibility#12
Open
chillpop wants to merge 4 commits into
Open
Conversation
added 4 commits
October 1, 2018 11:49
No longer a dependency for OptimizelySDK
Disabled these suggested warnings for less warning noise: - CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF - CLANG_WARN_STRICT_PROTOTYPES - GCC_WARN_UNDECLARED_SELECTOR
Optimizely no longer posts notifications using NSNotificationCenter. They now use OPTLYNotificationCenter which is a property on the OPTLYClient, not a singleton.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility with OptimizelySDK v2.
Optimizely no longer posts notifications using NSNotificationCenter. They now use OPTLYNotificationCenter which is a property on the OPTLYClient, not a singleton.
As a consequence, Optimizely must be fully initialized before Segment so that there is an instance of OPTLYClient for the SEGOptimizelyXIntegration to access when it is created.