[JourneysVs] - add presets for new journey event emitter by hema-segment · Pull Request #3750 · segmentio/action-destinations

hema-segment · 2026-04-23T14:02:10Z

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

Added unit tests for new functionality
Tested end-to-end using the local server
[If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
[Segmenters] Tested in the staging environment
[Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

Extracted all action API versions to verioning-info.ts file. example

Copilot

Pull request overview

Adds new Journey “all triggers” event presets to select audience destinations, and updates @segment/actions-core to a newer @segment/action-emitters build that presumably introduces/supports the new event emitter.

Changes:

Bumps @segment/action-emitters in @segment/actions-core to 1.3.9-canary.0 (and updates yarn.lock accordingly).
Adds a new preset for journeys_step_all_triggers_track to TikTok Audiences, DV360, Facebook Custom Audiences, and Google Enhanced Conversions.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
yarn.lock	Updates lockfile to include `@segment/action-emitters@1.3.9-canary.0`.
packages/core/package.json	Pins `@segment/action-emitters` to a canary pre-release.
packages/destination-actions/src/destinations/tiktok-audiences/index.ts	Adds a new “Journeys Step All Trigger” preset for the new Journey event slug.
packages/destination-actions/src/destinations/google-enhanced-conversions/index.ts	Adds a new “Journeys Step All Trigger” preset (only for `uploadCallConversion2`).
packages/destination-actions/src/destinations/facebook-custom-audiences/presets.ts	Adds a new “Journeys Step All Trigger” preset for the new Journey event slug.
packages/destination-actions/src/destinations/display-video-360/index.ts	Adds a new “Journeys Step All Trigger” preset for the new Journey event slug.

+    {
+      name: 'Journeys Step All Trigger',
+      partnerAction: 'uploadCallConversion2',
+      mapping: defaultValues(uploadCallConversion2.fields),
+      type: 'specificEvent',
+      eventSlug: 'journeys_step_all_triggers_track'
    }


codecov · 2026-04-23T14:10:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.11%. Comparing base (b93a98c) to head (e2ed5af).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3750      +/-   ##
==========================================
+ Coverage   81.08%   81.11%   +0.03%     
==========================================
  Files        1655     1656       +1     
  Lines       32079    32120      +41     
  Branches     7070     7116      +46     
==========================================
+ Hits        26011    26055      +44     
+ Misses       5096     5092       -4     
- Partials      972      973       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Adds presets to support the new Journeys event emitter (journeys_step_all_triggers_track) across select audience destinations, and updates the core @segment/action-emitters dependency to a newer version.

Changes:

Bumped @segment/action-emitters to 1.3.9 (and updated lockfile accordingly).
Added a new “Journeys Step All Triggers” preset for Facebook Custom Audiences and Google Enhanced Conversions.
Added TODO/commented-out presets for the same event in TikTok Audiences and Display & Video 360 (not yet enabled).

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
yarn.lock	Updates resolved `@segment/action-emitters` version to `1.3.9`.
packages/core/package.json	Bumps `@segment/action-emitters` dependency to `1.3.9` (currently pinned).
packages/destination-actions/src/destinations/tiktok-audiences/index.ts	Adds TODO/commented-out preset for `journeys_step_all_triggers_track`.
packages/destination-actions/src/destinations/google-enhanced-conversions/index.ts	Adds an enabled preset for `journeys_step_all_triggers_track`.
packages/destination-actions/src/destinations/facebook-custom-audiences/presets.ts	Adds an enabled preset for `journeys_step_all_triggers_track`.
packages/destination-actions/src/destinations/display-video-360/index.ts	Adds TODO/commented-out preset for `journeys_step_all_triggers_track`.

+    //TODO: uncomment this once the sync action is deployed
+    // https://github.com/segmentio/action-destinations/pull/3696/changes#diff-08e8fc99bc5b1d623022a7d1126485c0d0caf09a086c22e69a408cf8e9a4339e
+    // {
+    //   name: 'Journeys Step All Triggers',
+    //   partnerAction: 'syncAudience',
+    //   mapping: defaultValues(syncAudience.fields),
+    //   type: 'specificEvent',
+    //   eventSlug: 'journeys_step_all_triggers_track'
+    // }


      type: 'specificEvent',
      eventSlug: 'journeys_step_entered_track'
    }
+    //TODO: uncomment this once the sync action is deployed


  "dependencies": {
    "@lukeed/uuid": "^2.0.0",
-    "@segment/action-emitters": "^1.3.6",
+    "@segment/action-emitters": "1.3.9",


+    //TODO: uncomment this once the tik tok changes are applied as part of
+    // https://github.com/segmentio/action-destinations/pull/3732/changes#diff-820724a64b4d01bee37a38690220879172da2720386b7c98cd1c06d86275792a
+    // {
+    //   name: 'Journeys Step All Triggers',
+    //   partnerAction: 'syncAudience',
+    //   mapping: defaultValues(sync.fields),
+    //   type: 'specificEvent',
+    //   eventSlug: 'journeys_step_all_triggers_track'
+    // }


      type: 'specificEvent',
      eventSlug: 'journeys_step_entered_track'
    }
+    //TODO: uncomment this once the tik tok changes are applied as part of


      type: 'specificEvent',
      eventSlug: 'journeys_step_entered_track'
    }
+    //TODO: uncomment this once the tik tok changes are applied as part of


joe-ayoub-segment · 2026-04-27T08:40:38Z

Still in draft - @hema-segment will let me know when this is to be reviewed.

…dCallConversion2 The journeys_step_all_triggers_track preset should use the userList action (audience membership sync) not uploadCallConversion2 (call conversions).

Copilot

Pull request overview

Adds support for a new Journeys event slug by updating the action emitter dependency and introducing new presets that subscribe to the new Journeys “all triggers” event in supported destinations.

Changes:

Bumps @segment/action-emitters to 1.3.12 (and updates yarn.lock accordingly).
Adds a new Journeys Step All Triggers preset for Google Enhanced Conversions and Facebook Custom Audiences.
Adds commented-out (TODO) preset stubs for TikTok Audiences and Display & Video 360.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
yarn.lock	Updates lockfile to the newer `@segment/action-emitters` version.
packages/core/package.json	Updates `@segment/action-emitters` dependency version.
packages/destination-actions/src/destinations/google-enhanced-conversions/index.ts	Adds a `Journeys Step All Triggers` preset using `journeys_step_all_triggers_track`.
packages/destination-actions/src/destinations/facebook-custom-audiences/presets.ts	Adds a `Journeys Step All Triggers` preset using `journeys_step_all_triggers_track`.
packages/destination-actions/src/destinations/tiktok-audiences/index.ts	Adds a TODO/commented-out preset block for the new event.
packages/destination-actions/src/destinations/display-video-360/index.ts	Adds a TODO/commented-out preset block for the new event.

Copilot · 2026-04-30T19:29:51Z

  "dependencies": {
    "@lukeed/uuid": "^2.0.0",
-    "@segment/action-emitters": "^1.3.6",
+    "@segment/action-emitters": "1.3.12",


@segment/action-emitters is pinned to an exact version while the rest of this package’s dependencies use semver ranges. Unless there’s a specific reason to lock to exactly 1.3.12, consider switching back to a range (e.g., ^1.3.12) to receive patch/minor fixes and avoid unnecessary lockfile churn.

Suggested change

"@segment/action-emitters": "1.3.12",

"@segment/action-emitters": "^1.3.12",

Copilot · 2026-04-30T19:29:51Z

+    //TODO: uncomment this once the tik tok changes are applied as part of
+    // https://github.com/segmentio/action-destinations/pull/3732/changes#diff-820724a64b4d01bee37a38690220879172da2720386b7c98cd1c06d86275792a
+    // {
+    //   name: 'Journeys Step All Triggers',
+    //   partnerAction: 'syncAudience',
+    //   mapping: defaultValues(sync.fields),
+    //   type: 'specificEvent',
+    //   eventSlug: 'journeys_step_all_triggers_track'
+    // }


This adds a commented-out preset with a TODO to “uncomment later”, but uncommenting it won’t work as-is: it references sync/syncAudience that aren’t defined/imported in this file, and the array would also need a comma separator before the new element. Prefer removing the commented-out block and landing the preset in the PR that introduces the required action (or at least track it via an issue without leaving dead code in the presets array).

Suggested change

//TODO: uncomment this once the tik tok changes are applied as part of

// https://github.com/segmentio/action-destinations/pull/3732/changes#diff-820724a64b4d01bee37a38690220879172da2720386b7c98cd1c06d86275792a

// {

// name: 'Journeys Step All Triggers',

// partnerAction: 'syncAudience',

// mapping: defaultValues(sync.fields),

// type: 'specificEvent',

// eventSlug: 'journeys_step_all_triggers_track'

// }

Copilot · 2026-04-30T19:29:51Z

+    //TODO: uncomment this once the sync action is deployed
+    // https://github.com/segmentio/action-destinations/pull/3696/changes#diff-08e8fc99bc5b1d623022a7d1126485c0d0caf09a086c22e69a408cf8e9a4339e
+    // {
+    //   name: 'Journeys Step All Triggers',
+    //   partnerAction: 'syncAudience',
+    //   mapping: defaultValues(syncAudience.fields),
+    //   type: 'specificEvent',
+    //   eventSlug: 'journeys_step_all_triggers_track'
+    // }


This adds a commented-out preset with a TODO to “uncomment later”, but uncommenting it won’t work as-is: it references syncAudience that isn’t defined/imported or registered in this destination’s actions, and the presets array would need a comma separator before the new element. Prefer removing the commented-out block and landing the preset alongside the PR that adds the new action.

Suggested change

//TODO: uncomment this once the sync action is deployed

// https://github.com/segmentio/action-destinations/pull/3696/changes#diff-08e8fc99bc5b1d623022a7d1126485c0d0caf09a086c22e69a408cf8e9a4339e

// {

// name: 'Journeys Step All Triggers',

// partnerAction: 'syncAudience',

// mapping: defaultValues(syncAudience.fields),

// type: 'specificEvent',

// eventSlug: 'journeys_step_all_triggers_track'

// }

Copilot · 2026-04-30T19:29:52Z

      type: 'specificEvent',
      eventSlug: 'journeys_step_entered_track'
    }
+    //TODO: uncomment this once the tik tok changes are applied as part of


Nit: the comment says “tik tok”; please capitalize the brand consistently ("TikTok").

Suggested change

//TODO: uncomment this once the tik tok changes are applied as part of

//TODO: uncomment this once the TikTok changes are applied as part of

… into PT-2876

joe-ayoub-segment · 2026-05-06T07:53:51Z

Hi @hema-segment
There's a few Copilot review comments to respond to.
I think it would make sense to actually upgrade the emitter version in this PR too - then you can uncomment your presets.

… into PT-2876

…ons into PT-2876

add presets for new journey event emitter

e4e2017

Copilot AI review requested due to automatic review settings April 23, 2026 14:02

github-actions Bot added actions:core mode:cloud team:segment labels Apr 23, 2026

Copilot started reviewing on behalf of hema-segment April 23, 2026 14:02 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

update package

e892b2a

joe-ayoub-segment added the partner-eng-review (cloud) label Apr 24, 2026

joe-ayoub-segment self-assigned this Apr 24, 2026

joe-ayoub-segment changed the title ~~add presets for new journey event emitter~~ [JourneysVs] - add presets for new journey event emitter Apr 24, 2026

PT-2876: update version and new action

70c8b87

Copilot AI review requested due to automatic review settings April 26, 2026 14:37

Copilot started reviewing on behalf of hema-segment April 26, 2026 14:37 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Raghul Mukundan added 2 commits April 30, 2026 11:57

Update @segment/action-emitters to 1.3.12

b5066f1

Fix Google Enhanced Conversions preset: use userList instead of uploa…

e2ed5af

…dCallConversion2 The journeys_step_all_triggers_track preset should use the userList action (audience membership sync) not uploadCallConversion2 (call conversions).

Copilot AI review requested due to automatic review settings April 30, 2026 19:26

Copilot started reviewing on behalf of raghul-mukundan April 30, 2026 19:27 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

hema-segment added 2 commits May 5, 2026 07:48

update tiktok preset mapping

b0b80f3

Merge branch 'main' of ssh://github.com/segmentio/action-destinations…

ebf368b

… into PT-2876

hema-segment added 2 commits May 14, 2026 09:28

Merge branch 'main' of ssh://github.com/segmentio/action-destinations…

8d92765

… into PT-2876

Merge branch 'PT-2876' of ssh://github.com/segmentio/action-destinati…

118b460

…ons into PT-2876

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JourneysVs] - add presets for new journey event emitter#3750

[JourneysVs] - add presets for new journey event emitter#3750
hema-segment wants to merge 9 commits into
mainfrom
PT-2876

hema-segment commented Apr 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

joe-ayoub-segment commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

joe-ayoub-segment commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	"@segment/action-emitters": "1.3.12",
	"@segment/action-emitters": "^1.3.12",

	//TODO: uncomment this once the tik tok changes are applied as part of
	//TODO: uncomment this once the TikTok changes are applied as part of

Conversation

hema-segment commented Apr 23, 2026

Testing

Security Review

New Destination Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

joe-ayoub-segment commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

joe-ayoub-segment commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Apr 23, 2026 •

edited

Loading