Skip to content

Update @segment/action-emitters to v1.3.11#3771

Open
kkolhe-twilio wants to merge 1 commit into
mainfrom
ACTVTNS-623/update-emitters-02
Open

Update @segment/action-emitters to v1.3.11#3771
kkolhe-twilio wants to merge 1 commit into
mainfrom
ACTVTNS-623/update-emitters-02

Conversation

@kkolhe-twilio
Copy link
Copy Markdown
Contributor

@kkolhe-twilio kkolhe-twilio commented Apr 30, 2026

Summary

Updates @segment/action-emitters package from v1.3.6 to v1.3.11 to support Entity Data Freshness feature.

What's new in v1.3.11:

  • Adds warehouse_entity_values_changed_track trigger - fires when entity property values change
  • Adds warehouse_all_triggers_track trigger - combined trigger for entity add/remove/change events

Why needed:
Control Plane must recognize and validate these new trigger types when they're used in activations. Without this update, the new triggers would be rejected during activation creation.

Downstream impact:

  • Frontend (app repo) also needs to update to v1.3.11
  • Compute team implementing backend detection logic (separate effort)

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Merged to stage and allowed to run for >= 4 hours.
  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

Copilot AI review requested due to automatic review settings April 30, 2026 15:23
@kkolhe-twilio kkolhe-twilio requested a review from a team as a code owner April 30, 2026 15:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the @segment/actions-core package’s dependency on @segment/action-emitters to v1.3.11 so the repo can recognize and validate new Entity Data Freshness trigger types used in activations.

Changes:

  • Bump @segment/action-emitters from v1.3.6 to v1.3.11 in packages/core.
  • Regenerate yarn.lock for the new package version and updated transitive dependencies.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/core/package.json Updates @segment/action-emitters dependency version used by actions-core.
yarn.lock Lockfile updates reflecting the new @segment/action-emitters version and transitive dependency resolution changes.

"dependencies": {
"@lukeed/uuid": "^2.0.0",
"@segment/action-emitters": "^1.3.6",
"@segment/action-emitters": "1.3.11",
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@segment/action-emitters was changed from a caret range (^1.3.6) to an exact version (1.3.11). This is inconsistent with how other dependencies (including other @segment/* packages) are versioned in this repo (e.g. @segment/actions-core uses ^... in packages/destination-actions/package.json:50 and packages/browser-destination-runtime/package.json:65). Consider switching this to ^1.3.11 unless there’s a specific reason to pin exactly, so patch/minor fixes can flow without manual updates.

Suggested change
"@segment/action-emitters": "1.3.11",
"@segment/action-emitters": "^1.3.11",

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to use 1.3.11

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.11%. Comparing base (48b53d2) to head (04965e4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3771   +/-   ##
=======================================
  Coverage   81.11%   81.11%           
=======================================
  Files        1656     1656           
  Lines       32120    32120           
  Branches     7102     7067   -35     
=======================================
  Hits        26055    26055           
- Misses       5092     5108   +16     
+ Partials      973      957   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread yarn.lock
buffer "^5.2.1"
through "^2.3.8"

undici-types@~5.26.4:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's this one coming from?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undici-types comes from the newer @types/node version.

  1. I updated @segment/action-emitters to 1.3.11
  2. It needs @types/node@^18.11.15 (18.11.15 or higher)
  3. Yarn picked @types/node@18.19.130 during yarn install
  4. That newer @types/node requires undici-types@~5.26.4

Comment thread yarn.lock
version "18.11.15"
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.11.15.tgz#de0e1fbd2b22b962d45971431e2ae696643d3f5d"
integrity sha512-VkhBbVo2+2oozlkdHXLrb3zjsRkpdnaU2bXmX8Wgle3PUi569eLRaHGlgETQHR7lLL1w7GiG3h9SnePhxNDecw==
version "18.19.130"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this strictly needed? Can the change be removed somehow? same with undici-types ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are automatic yarn updates for @types/node. They happened because action-emitters allows any 18.x version. The changes are just type definitions, not runtime code.

undici-types comes from the newer @types/node version.

here is the flow:

undici-types comes from the newer @types/node version.

  1. I updated @segment/action-emitters to 1.3.11
  2. It needs @types/node@^18.11.15 (18.11.15 or higher)
  3. Yarn picked @types/node@18.19.130 during yarn install
  4. That newer @types/node requires undici-types@~5.26.4

@joe-ayoub-segment
Copy link
Copy Markdown
Contributor

joe-ayoub-segment commented May 5, 2026

Hi @kkolhe-twilio
We'll need to deploy your PR to staging before we deploy to prod.
You'll also need to ensure that the same version of the emitter is deployed on any upstream service.

@hema-segment from the Journeys team has version 1.3.12 in staging right now for testing, so please coordinate with her to figure out when your version should be deployed to staging - and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants