Update @segment/action-emitters to v1.3.11#3771
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the @segment/actions-core package’s dependency on @segment/action-emitters to v1.3.11 so the repo can recognize and validate new Entity Data Freshness trigger types used in activations.
Changes:
- Bump
@segment/action-emittersfrom v1.3.6 to v1.3.11 inpackages/core. - Regenerate
yarn.lockfor the new package version and updated transitive dependencies.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/core/package.json |
Updates @segment/action-emitters dependency version used by actions-core. |
yarn.lock |
Lockfile updates reflecting the new @segment/action-emitters version and transitive dependency resolution changes. |
| "dependencies": { | ||
| "@lukeed/uuid": "^2.0.0", | ||
| "@segment/action-emitters": "^1.3.6", | ||
| "@segment/action-emitters": "1.3.11", |
There was a problem hiding this comment.
@segment/action-emitters was changed from a caret range (^1.3.6) to an exact version (1.3.11). This is inconsistent with how other dependencies (including other @segment/* packages) are versioned in this repo (e.g. @segment/actions-core uses ^... in packages/destination-actions/package.json:50 and packages/browser-destination-runtime/package.json:65). Consider switching this to ^1.3.11 unless there’s a specific reason to pin exactly, so patch/minor fixes can flow without manual updates.
| "@segment/action-emitters": "1.3.11", | |
| "@segment/action-emitters": "^1.3.11", |
There was a problem hiding this comment.
want to use 1.3.11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3771 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 1656 1656
Lines 32120 32120
Branches 7102 7067 -35
=======================================
Hits 26055 26055
- Misses 5092 5108 +16
+ Partials 973 957 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| buffer "^5.2.1" | ||
| through "^2.3.8" | ||
|
|
||
| undici-types@~5.26.4: |
There was a problem hiding this comment.
where's this one coming from?
There was a problem hiding this comment.
undici-types comes from the newer @types/node version.
- I updated @segment/action-emitters to 1.3.11
- It needs @types/node@^18.11.15 (18.11.15 or higher)
- Yarn picked @types/node@18.19.130 during yarn install
- That newer @types/node requires undici-types@~5.26.4
| version "18.11.15" | ||
| resolved "https://registry.yarnpkg.com/@types/node/-/node-18.11.15.tgz#de0e1fbd2b22b962d45971431e2ae696643d3f5d" | ||
| integrity sha512-VkhBbVo2+2oozlkdHXLrb3zjsRkpdnaU2bXmX8Wgle3PUi569eLRaHGlgETQHR7lLL1w7GiG3h9SnePhxNDecw== | ||
| version "18.19.130" |
There was a problem hiding this comment.
is this strictly needed? Can the change be removed somehow? same with undici-types ?
There was a problem hiding this comment.
These are automatic yarn updates for @types/node. They happened because action-emitters allows any 18.x version. The changes are just type definitions, not runtime code.
undici-types comes from the newer @types/node version.
here is the flow:
undici-types comes from the newer @types/node version.
- I updated @segment/action-emitters to 1.3.11
- It needs @types/node@^18.11.15 (18.11.15 or higher)
- Yarn picked @types/node@18.19.130 during yarn install
- That newer @types/node requires undici-types@~5.26.4
|
Hi @kkolhe-twilio @hema-segment from the Journeys team has version 1.3.12 in staging right now for testing, so please coordinate with her to figure out when your version should be deployed to staging - and let me know. |
Summary
Updates
@segment/action-emitterspackage from v1.3.6 to v1.3.11 to support Entity Data Freshness feature.What's new in v1.3.11:
warehouse_entity_values_changed_tracktrigger - fires when entity property values changewarehouse_all_triggers_tracktrigger - combined trigger for entity add/remove/change eventsWhy needed:
Control Plane must recognize and validate these new trigger types when they're used in activations. Without this update, the new triggers would be rejected during activation creation.
Downstream impact:
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example