feat: add metadata.json for browser destinations (40 files)#3774
Draft
varadarajan-tw wants to merge 4 commits into
Draft
feat: add metadata.json for browser destinations (40 files)#3774varadarajan-tw wants to merge 4 commits into
varadarajan-tw wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (31.86%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3774 +/- ##
===========================================
- Coverage 81.11% 31.86% -49.26%
===========================================
Files 1656 15 -1641
Lines 32120 747 -31373
Branches 7118 125 -6993
===========================================
- Hits 26055 238 -25817
+ Misses 5108 509 -4599
+ Partials 957 0 -957 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ad-browser Accept incoming browser metadata.json changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 35 out of 40 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (2)
packages/browser-destinations/destinations/heap/metadata.json:42
- Spelling: "For most cased" should be "For most cases" (user-facing description). Since metadata.json is generated, fix in the source destination settings text and regenerate.
"description": "This is an optional setting. This is used to set up first-party data collection. For most cased this should not be set. For more information visit the Heap [docs page](https://developers.heap.io/docs/web#ingestserver).",
packages/browser-destinations/destinations/hubble-web/metadata.json:137
- Spelling: "identifer" should be "identifier" in this user-facing field description. Since metadata.json is generated, fix the typo in the source destination/action definition and regenerate.
"description": "Unique identifer of the user",
| }, | ||
| "useSegmentId": { | ||
| "label": "Use Segment's Anonymous ID as the Evolv user id", | ||
| "description": "When using this option, Evolv AI will levarage the Segment Anonymous ID instead of generating a new user id.", |
| }, | ||
| "trackingServer": { | ||
| "label": "Tracking Server (deprecated)", | ||
| "description": "This is an optional setting. This is used to set up first-party data collection. For most cased this should not be set. For more information visit the Heap [docs page](https://developers.heap.io/docs/set-up-first-party-data-collection-in-heap). This field is deprecated in favor of `ingestServer`. If `trackingServer` is set and `ingestServer` is not set, then the Classic SDK will be loaded. If both are set, `ingestServer` will take precedence, and the latest stable version of the Heap SDK will be loaded.", |
| }, | ||
| "hostname": { | ||
| "label": "Hostname", | ||
| "description": "This is an optional setting used to set the host that loads the Heap SDK. This setting is used when the Heap SDK is self-hosted. In most cased this should be left unset. The hostname should not contain https or app id. When _both_ `hostname` and `trackingServer` are set, the Classic SDK will be loaded via: `https://${hostname}/js/heap-${appId}.js`. If `hostname` is set and `trackingServer` is not set, then the latest version of the Heap SDK will be loaded via: `https://${settings.hostname}/config/${settings.appId}/heap_config.js`. For more information visit the Heap [docs page](https://developers.heap.io/docs/self-hosting-heapjs).", |
| }, | ||
| "userId": { | ||
| "label": "User ID", | ||
| "description": "Unique identifer of the user", |
Regenerated with latest generate:metadata-payload output including syncMode, hooks, and audienceConfig enhancements. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated
metadata.jsonfiles for all 40 browser destinations. This is PR 2 of 4.What
Adds co-located
metadata.jsonto each browser destination underpackages/browser-destinations/destinations/*/.Files are generated by
yarn generate:metadata-payload(added in PR 1).Series
metadata.jsonfiles — draftmetadata.jsonfiles — draftci.yml— draft