feat: assert metadata.json files are up-to-date in CI validate job#3776
Draft
varadarajan-tw wants to merge 1 commit into
Draft
feat: assert metadata.json files are up-to-date in CI validate job#3776varadarajan-tw wants to merge 1 commit into
varadarajan-tw wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI validation guard to ensure generated metadata.json payloads are committed and current, by running an assertion script during the existing validate job.
Changes:
- Adds a new
validatejob step to runbash scripts/assert-metadata-payload.sh.
| run: bash scripts/assert-types-updated.sh | ||
|
|
||
| - name: Assert metadata payloads are up-to-date | ||
| run: bash scripts/assert-metadata-payload.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
assert-metadata-payload.shcheck to the CI validate job. This is PR 4 of 4 — merge last, after PRs 2 and 3.What
Adds a step to
.github/workflows/ci.ymlthat runsbash scripts/assert-metadata-payload.shin the validate job, ensuringmetadata.jsonfiles are always committed and up-to-date.Series
metadata.jsonfilesmetadata.jsonfiles