STRATCONN-6602 - [Google Enhanced Conversions] - Journeysv2 support#3784
STRATCONN-6602 - [Google Enhanced Conversions] - Journeysv2 support#3784joe-ayoub-segment wants to merge 10 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Journeys v2 support for Google Enhanced Conversions userList syncing by threading Personas/Journeys context (audienceMembership, personasContext) into the action and using a feature-flagged code path to decide add/remove operations.
Changes:
- Extend
userListactionperform/performBatchto receive and pass throughaudienceMembershipandpersonasContext. - Update GEC userList identifier extraction / operation-type selection to optionally use audience membership signals (feature-flagged).
- Extend
Personastype in core destination-kit to includecomputation_class.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts | Passes audienceMembership and personasContext into userList processing functions. |
| packages/destination-actions/src/destinations/google-enhanced-conversions/userList/constants.ts | Adds a Journeys support flag constant (currently unused). |
| packages/destination-actions/src/destinations/google-enhanced-conversions/functions.ts | Implements feature-flagged audience-membership/Journeys logic for add/remove decisions in single + batch flows. |
| packages/core/src/destination-kit/index.ts | Updates Personas typing to include computation_class. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3784 +/- ##
==========================================
+ Coverage 80.84% 81.22% +0.37%
==========================================
Files 1377 1409 +32
Lines 26417 28463 +2046
Branches 5581 6194 +613
==========================================
+ Hits 21357 23118 +1761
- Misses 4097 4363 +266
- Partials 963 982 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts:27
- Changing
syncMode.defaultfrom'add'to'mirror'is a user-facing behavior change for any existing mappings that relied on the default (i.e. didn’t explicitly set__segment_internal_sync_mode). Please confirm this is intended and backward-compatible; if not, consider keeping the previous default or gating the new default behind a feature flag / version bump.
syncMode: {
description: 'Define how the records will be synced to Google',
label: 'How to sync records',
default: 'mirror',
choices: [
{ label: 'Adds users to the connected Google Customer Match User List', value: 'add' },
{ label: 'Remove users from the connected Google Customer Match User List', value: 'delete' },
{ label: 'Add and remove users in the connected Google Customer Match User List', value: 'mirror' }
]
PR to add Journeys V2 support to Google Enhanced Conversions userList action.
Testing
Tested locally.
Need staging test
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example