Skip to content

STRATCONN-6602 - [Google Enhanced Conversions] - Journeysv2 support#3784

Open
joe-ayoub-segment wants to merge 10 commits into
mainfrom
gec-journeys2-support
Open

STRATCONN-6602 - [Google Enhanced Conversions] - Journeysv2 support#3784
joe-ayoub-segment wants to merge 10 commits into
mainfrom
gec-journeys2-support

Conversation

@joe-ayoub-segment
Copy link
Copy Markdown
Contributor

@joe-ayoub-segment joe-ayoub-segment commented May 12, 2026

PR to add Journeys V2 support to Google Enhanced Conversions userList action.

Testing

Tested locally.

Need staging test

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Journeys v2 support for Google Enhanced Conversions userList syncing by threading Personas/Journeys context (audienceMembership, personasContext) into the action and using a feature-flagged code path to decide add/remove operations.

Changes:

  • Extend userList action perform/performBatch to receive and pass through audienceMembership and personasContext.
  • Update GEC userList identifier extraction / operation-type selection to optionally use audience membership signals (feature-flagged).
  • Extend Personas type in core destination-kit to include computation_class.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts Passes audienceMembership and personasContext into userList processing functions.
packages/destination-actions/src/destinations/google-enhanced-conversions/userList/constants.ts Adds a Journeys support flag constant (currently unused).
packages/destination-actions/src/destinations/google-enhanced-conversions/functions.ts Implements feature-flagged audience-membership/Journeys logic for add/remove decisions in single + batch flows.
packages/core/src/destination-kit/index.ts Updates Personas typing to include computation_class.

Comment thread packages/core/src/destination-kit/index.ts Outdated
Copilot AI review requested due to automatic review settings May 12, 2026 08:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Comment thread packages/core/src/destination-kit/index.ts Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.22%. Comparing base (139ddfe) to head (34f46ed).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...tinations/google-enhanced-conversions/functions.ts 94.59% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3784      +/-   ##
==========================================
+ Coverage   80.84%   81.22%   +0.37%     
==========================================
  Files        1377     1409      +32     
  Lines       26417    28463    +2046     
  Branches     5581     6194     +613     
==========================================
+ Hits        21357    23118    +1761     
- Misses       4097     4363     +266     
- Partials      963      982      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings May 12, 2026 10:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts:27

  • Changing syncMode.default from 'add' to 'mirror' is a user-facing behavior change for any existing mappings that relied on the default (i.e. didn’t explicitly set __segment_internal_sync_mode). Please confirm this is intended and backward-compatible; if not, consider keeping the previous default or gating the new default behind a feature flag / version bump.
  syncMode: {
    description: 'Define how the records will be synced to Google',
    label: 'How to sync records',
    default: 'mirror',
    choices: [
      { label: 'Adds users to the connected Google Customer Match User List', value: 'add' },
      { label: 'Remove users from the connected Google Customer Match User List', value: 'delete' },
      { label: 'Add and remove users in the connected Google Customer Match User List', value: 'mirror' }
    ]

Comment thread packages/core/src/destination-kit/index.ts Outdated
@joe-ayoub-segment joe-ayoub-segment marked this pull request as ready for review May 12, 2026 14:05
Copilot AI review requested due to automatic review settings May 12, 2026 14:05
@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner May 12, 2026 14:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Comment thread packages/core/src/destination-kit/index.ts Outdated
Copilot AI review requested due to automatic review settings May 13, 2026 15:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comment thread packages/core/src/destination-kit/index.ts Outdated
Comment thread packages/cli/src/lib/server.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants