Skip signature event building during Cosmos CheckTx/ReCheckTx#3230
Open
amir-deris wants to merge 2 commits intomainfrom
Open
Skip signature event building during Cosmos CheckTx/ReCheckTx#3230amir-deris wants to merge 2 commits intomainfrom
amir-deris wants to merge 2 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
=======================================
Coverage 59.01% 59.01%
=======================================
Files 2065 2065
Lines 169369 169371 +2
=======================================
+ Hits 99956 99960 +4
+ Misses 60649 60648 -1
+ Partials 8764 8763 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bdchatham
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckTxandReCheckTx,CheckSignatureswas unconditionally building signature events (account sequence formatting,SignatureDataToBz, base64 encoding) even thoughCosmosCheckTxAntediscards them with_.skipSigEventsguard so this work is skipped whenctx.IsCheckTx() || ctx.IsReCheckTx()— reducing allocations and CPU on the highest-frequency ante path.CosmosDeliverTxAnteis unaffected: its context always has both flags false, so events are still built and emitted normally.Result
In branch
amir/PLT-218-analyze-app-performance, running 4 node cluster and doingsei-chain/loadtestfor CosmosBankandStakingtransaction types, and taking pprof CPU profiles at specific heights, we observe about 15% less CPU usage inCosmosCheckTxAnte.