refactor: simplify NetworkingConfig to public/private presence signal#76
Merged
refactor: simplify NetworkingConfig to public/private presence signal#76
Conversation
Strip NetworkingConfig down to an empty struct. The presence of
networking: {} means public (ClusterIP Service + HTTPRoutes),
absence means private (headless Services only).
Removed:
- ExternalServiceConfig (Type, Annotations) — always ClusterIP now
- GatewayRouteConfig — unused annotation passthrough
- NetworkIsolationConfig / AuthorizationPolicy — deferred until
isolation requirements are defined
- LoadBalancer readiness gate — replaced with DNS hostname check
- External P2P address propagation — LB-specific, no longer applies
- ControllerSA field — only used by removed AuthorizationPolicy
- ConditionExternalServiceReady, ConditionIsolationReady conditions
- AuthorizationPolicy RBAC markers
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove SEI_CONTROLLER_SA_PRINCIPAL from base manager manifest
- Update sample manifest to use networking: {} (removed stale schema)
- Restore ServiceMonitor orphaning on Retain deletion policy
- Fix stale comments referencing LoadBalancer and AuthorizationPolicy
- Update Networking field godoc to reflect public/private semantics
- Rename external_address_test.go to route_resolvable_test.go
- Regenerate CRDs with updated field descriptions
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NetworkingConfigto an empty struct —networking: {}= public, omitted = privateExternalServiceConfig,GatewayRouteConfig,NetworkIsolationConfig,AuthorizationPolicyConfig,TrafficSourceBehavioral model
networkingomittednetworking: {}What's deferred (not removed permanently)
NetworkingConfiglater.Test plan
make test)make lint)🤖 Generated with Claude Code