Repository navigation
Conversation
…trip Extend the wire stability test to assert that the abandoned execution outcome deserializes from its wire name and serializes back to the same string. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add an Abandoned variant to ExecutionOutcome for runs that were abandoned before their effects could be determined, and map the legacy "aborted" value to it instead of Cancelled. The contract version is bumped to 1.28 and the v1 fixture updated to match the new vocabulary. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add a test asserting that recording an abandoned execution persists it as a terminal executed state with an unknown effect, that replaying the same request is idempotent, and that a later conflicting outcome is rejected. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the wire and scoped wire tests to expect contract version 1.28 instead of 1.27, and adjust the compatibility comment accordingly. The approval engine test assertion is only reformatted to satisfy rustfmt. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Owner
Author
|
Superseded by canonical upstream PR tinyhumansai#43. Please review the upstream PR for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TinySecurity now records an abandoned in-flight approved execution as
abandoned, preserving that its effects are unknown. The outcome is a distinct versioned bus value (contract 1.28), persists as an immutable terminal result, and legacyabortedmaps to this outcome instead of explicit cancellation.Refs tinyhumansai#1
Part of tinyhumansai/openhuman#7328
Validation:
cargo test -p tinysecurity-buscargo test -p tinysecurity-approvalcargo check -p tinysecurity-bus -p tinysecurity-approvalcargo clippy -p tinysecurity-bus -p tinysecurity-approval --all-targets -- -D warningscargo fmt --all -- --check