Conversation
…spatchEvent function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new JSON schema files for game assets and refactors core engine classes to improve scene and game object management. The most significant changes are the addition of asset schemas for game objects, scenes, prefabs, and vectors, as well as major restructuring of the
AbstractSceneandGameObjectclasses to clarify responsibilities and improve code organization.Asset Schema Additions:
gameobject.schema.json,scene.schema.json,prefab.schema.json, andvector2.schema.jsonto define structured formats for game objects, scenes, prefabs, and vector data, enabling better data validation and interoperability. [1] [2] [3] [4]composer.jsondependencies to includeswaggest/json-schemaandsymfony/polyfill-php83for schema validation and compatibility.Core Engine Refactoring (
AbstractScene):AbstractSceneclass, moving properties and methods for scene lifecycle (awake,load,unload,start,stop,isStarted,isStopped) to clarify their purpose and improve maintainability. Scene metadata can now be injected via the constructor. [1] [2] [3] [4] [5]createWorldSpace,setWorldSpace,setCollisionWorldSpace). [1] [2] [3]Core Engine Refactoring (
GameObject):render,erase, andisActivemethods, and ensured thegetRenderermethod is properly defined and documented. [1] [2] [3] [4] [5]Examples and Miscellaneous:
pongwith its owncomposer.json,.gitignore, and splash texture. Updated the collector example's splash texture for improved visual style. [1] [2] [3] [4]These changes collectively improve the structure, maintainability, and extensibility of the engine and its asset pipeline.