Conversation
… code readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements and clarifications to the Sendama engine's scene system, focusing on scene file structure, object instantiation, and better support for UI elements. The most notable changes include the addition of comprehensive documentation for scene files, a migration from
Texture2Dto a more generalTextureclass, and enhanced scene hierarchy parsing to support both game objects and UI elements.Key changes:
Documentation and Authoring
docs/Serialization/Scenes.md) explaining the structure, conventions, and lifecycle of Sendama scene files, including examples for game objects, components, sprites, and UI elements.Texture Handling
Texture2Dwith the more generalTextureclass across core interfaces, implementations, and documentation, simplifying texture management for sprites. [1] [2] [3] [4] [5] [6] [7]Scene Hierarchy and Object Instantiation
SceneManagerto:GameObjectand UI elements (Label,Text) as top-level scene objects.typefield in scene metadata.Core Logic and Lifecycle
updatePhysicsmethod to theSceneManagerfor explicit physics updates.UI and Scene Presentation
TitleScene, making UI layout more robust and maintainable. [1] [2] [3]These changes make scene authoring more declarative and flexible, improve documentation and onboarding, and lay the groundwork for richer UI integration in scenes.