Conversation
…hance pause/resume logic in game states
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to engine component metadata hydration, improves pause and scene state transitions, and adds new tests to ensure correct behavior. Key changes include improved handling of pause/resume logic, more comprehensive scene metadata hydration (including native and compound types), and the addition of a
Rangeattribute for property constraints.Engine metadata hydration improvements:
Texture,Rect,Sprite, and colors), and compound structures from scene metadata. New probe classes and test cases were introduced to cover these scenarios. [1] [2] [3]Pause and scene state logic:
PausedStateandSceneStateto only resume or suspend when the relevant state is present, preventing unintended updates or transitions. [1] [2]PausedStateto ensure the pause menu does not update on the frame resume is requested, and added helper methods for managing input state in tests. [1] [2]SceneStateto verify that the active scene does not advance when pause is pressed, with a dedicated test game class to manage state transitions.Texture class enhancements:
requestedWidthandrequestedHeightproperties to theTextureclass, along with corresponding getters, to retain and expose the original authoring constraints for textures. [1] [2] [3]Attributes and constraints:
Rangeattribute to allow property constraints (min, max, step) to be specified for properties, providing a foundation for future validation or UI tooling.Test infrastructure improvements:
PausedStateTestandSceneStateTestto support explicit state registration, retrieval, and transitions, enabling more robust and isolated testing of stateful engine behavior. [1] [2]