Fix clap --targets parsing issue#351
Closed
neunenak wants to merge 1 commit into
Closed
Conversation
I was seeing the following issue when trying to deploy a subset of targets defined in my flake: ``` ❯ deploy --targets ".#flake-one" ".#flake-two" error: the argument '--targets <TARGETS>' cannot be used with '[TARGET]' Usage: deploy --targets <TARGETS> [TARGET] [EXTRA_BUILD_ARGS]... ``` The problem turned out to be a result of the way the clap macro was defining the `targets` command line argument - it was interpreting the last argument to --targets as being the <target> position argument, and then treating them as two incompatible uses of commands from the same argument grup. Adding `num_args...` fixes this behavior.
Author
|
Closing, I didnt realize #341 fixes the same issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing the following issue when trying to deploy a subset of targets defined in my flake:
The problem turned out to be a result of the way the clap macro was defining the
targetscommand line argument - it was interpreting the last argument to --targets as being the position argument, and then treating them as two incompatible uses of commands from the same argument grup.Adding
num_args...fixes this behavior.