OHOS: Implement a maximum number of failed runner spawns before exiting#121
Draft
Narfinger wants to merge 4 commits into
Draft
OHOS: Implement a maximum number of failed runner spawns before exiting#121Narfinger wants to merge 4 commits into
Narfinger wants to merge 4 commits into
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jschwe
reviewed
Mar 31, 2026
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jschwe
reviewed
Apr 1, 2026
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Member
|
Note: currently undergoing testing on hos-ci1. |
Member
|
Hmm, doesn't seem to be working as intended (after deleting the image, I expected growing retry times, and self-exit). I also enabled debug logging later, but that didn't add more useful information. It seems we don't see the docker spawn command failing, which is wierd. Needs more investigation at a later time, maybe I'm missing something in the code. |
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jschwe
reviewed
Apr 1, 2026
|
|
||
| // The above command will not give an error if the docker command exists | ||
| // but the command exited with failure. | ||
| std::thread::sleep(Duration::from_millis(100)); |
Member
There was a problem hiding this comment.
looks like this might need to be ~2 seconds. time reports around 1.1s before docker run non_existing_local_image --rm returns.
Member
There was a problem hiding this comment.
I think perhaps we should move the retries.reset() to the place where we check if the container exited. Exit code 125 means docker run failed. Can we get the actual runtime from the exit status? If yes maybe besides checking the exit code we could also do a heuristic (shorter than 5 seconds probably means something went wrong)
Contributor
Author
There was a problem hiding this comment.
Ok then I need to rething this a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will stop the docker_jit_container if we are spawning runners but there is a problem with spawning it on our side.