Skip to content

Add arg to set single label mode#125

Open
janeoa wants to merge 7 commits into
servo:mainfrom
janeoa:split-usb
Open

Add arg to set single label mode#125
janeoa wants to merge 7 commits into
servo:mainfrom
janeoa:split-usb

Conversation

@janeoa
Copy link
Copy Markdown
Contributor

@janeoa janeoa commented Apr 29, 2026

This is to be able to host builder and runner separately by passing an argument

Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
@janeoa janeoa requested a review from jschwe as a code owner April 29, 2026 14:33
@Narfinger
Copy link
Copy Markdown
Contributor

I think we can do the following: Remove the single() from ContainerTypeIterator and just fill the remaining vec
Perhaps even a impl From<SingleLabelMode> for ContainerTypeIterator that is basically just your fn container_types.
I also wonder if the SingleLabelMode should have a different name. Something like container mode so that the both case is better included.

jschwe and others added 5 commits May 5, 2026 10:21
Git sees the redundant `target/` that my IDE keeps building. I could
"fix" it by some local settings on my machine, but it might be helpful
to have it in the .gitignore

Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
@janeoa janeoa requested a review from delan as a code owner May 5, 2026 08:21
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants