Add optional SDK path arg to the build.sh#127
Open
janeoa wants to merge 3 commits into
Open
Conversation
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Member
Is this behind a proxy? Also in production, we actually commented this and |
Narfinger
approved these changes
May 4, 2026
Contributor
Narfinger
left a comment
Narfinger
left a comment
There was a problem hiding this comment.
Can you just add a print at the start, something like: "Using sdk version $VERSION from web.
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Narfinger
approved these changes
May 5, 2026
janeoa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the local images using podman, it failes to download the SDK due to 403 error (does not happen on docker for some reason).
So I added an optional arg to the
build.sh, so that the build script could use locally pre-downloaded SDK of any version for image building.It also supports
-h/--helpjust in case