Skip to content

Audit update - #1199

Merged
alejandro-colomar merged 3 commits into
shadow-maint:masterfrom
ikerexxe:audit-update
Mar 3, 2025
Merged

Audit update#1199
alejandro-colomar merged 3 commits into
shadow-maint:masterfrom
ikerexxe:audit-update

Conversation

@ikerexxe

@ikerexxe ikerexxe commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

This is a set of changes that Fedora introduced in a downstream patch. The idea is to converge upstream and downstream versions to reduce the maintenance burden. The patch was created a long time ago and we have been adapting it, but it may not be up to date with current upstream code standards, if so, please inform me so I can update the patch.

@ikerexxe ikerexxe mentioned this pull request Jan 27, 2025
Closed
@ikerexxe

ikerexxe commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator Author

@stevegrubb before I take this out of draft status, are there any other distributions besides Fedora/CentOS/RHEL that might be affected by these changes? I'd like to ping the maintainers of those distributions to review these code changes.

alejandro-colomar
alejandro-colomar reviewed Jan 27, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Jan 27, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Jan 27, 2025
View reviewed changes
Comment thread lib/audit_help.c
alejandro-colomar
alejandro-colomar reviewed Jan 27, 2025
View reviewed changes
Comment thread lib/prototypes.h Outdated
alejandro-colomar
alejandro-colomar reviewed Jan 27, 2025
View reviewed changes
Comment thread src/gpasswd.c
alejandro-colomar
alejandro-colomar reviewed Jan 27, 2025
View reviewed changes
Comment thread src/groupadd.c
alejandro-colomar
alejandro-colomar reviewed Jan 30, 2025
View reviewed changes
Comment thread lib/prototypes.h Outdated
Comment thread lib/cleanup_group.c
@stevegrubb

stevegrubb commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

@ikerexxe Most major distributions enable auditing. So, they are all affected. That said, they are all broken except Fedora. This fixes everyone and Fedora can drop it's patch.

@ikerexxe
ikerexxe marked this pull request as ready for review February 6, 2025 08:44
@ikerexxe

ikerexxe commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator Author

@ikerexxe Most major distributions enable auditing. So, they are all affected. That said, they are all broken except Fedora. This fixes everyone and Fedora can drop it's patch.

Thank you for the clarification. I'm moving the PR out of draft state.

alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/cleanup_group.c
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar
alejandro-colomar reviewed Feb 10, 2025
View reviewed changes
Comment thread src/newgrp.c
@ikerexxe
ikerexxe force-pushed the audit-update branch 2 times, most recently from 07ff120 to 8c33c7f Compare February 13, 2025 09:10
alejandro-colomar
alejandro-colomar reviewed Feb 25, 2025
View reviewed changes
Comment thread lib/audit_help.c Outdated
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request May 30, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
a893897 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jun 2, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
1165482 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jun 3, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
245eb12 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jun 3, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
251a7a4 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jun 4, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
6d95c0c 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jun 7, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
4d8cd82 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jul 1, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
4ce54e2 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jul 17, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
52ebd0a 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jul 20, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
3c1f7f0 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Aug 16, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
e1ef21c 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Sep 30, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
4eec24a 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Oct 19, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
d3f10c1 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Oct 24, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
5d97ae3 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Oct 24, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
0b5eddd 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Oct 28, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
5057456 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Oct 28, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
3367a6a 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Oct 28, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
4339485 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Nov 10, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
a0e5a7e 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Nov 28, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
bbf8b9b 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Nov 28, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
97a7be9 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Dec 4, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
2eb4d90 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Dec 6, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
a368332 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Dec 6, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
3e5783a 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Dec 24, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
69e3174 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Dec 26, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
7475164 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Dec 26, 2025
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
b36a9eb 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Feb 20, 2026
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
e7bdeb9 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Feb 26, 2026
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
5414bd6 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Mar 4, 2026
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
dbed742 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar added a commit to alejandro-colomar/shadow that referenced this pull request Jun 20, 2026
@alejandro-colomar
lib/audit_help.c: We don't support names that need encoding
5ae6e42 
See is_valid_name(), which reports EINVAL for any such names.

Link: <shadow-maint#1199 (comment)>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alejandro-colomar alejandro-colomar alejandro-colomar approved these changes
+1 more reviewer
@stevegrubb stevegrubb stevegrubb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikerexxe @stevegrubb @alejandro-colomar