fix: clarify --reference with parameterized --prepare (fixes #847)#878
Open
leno23 wants to merge 1 commit into
Open
fix: clarify --reference with parameterized --prepare (fixes #847)#878leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When --reference is used with --prepare/--conclude templates that contain
{parameter} placeholders, skip those hooks for the reference benchmark (it has
no parameters to substitute). Document how --reference relates to parameterized
benchmarks.
Fixes sharkdp#847
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
CI green on all targets. Gentle ping when you have a moment — thanks! |
Author
|
Friendly ping when convenient — documents |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--reference, parameterized benchmarks (-L/--parameter-scan), and--prepare 'sleep {delay}': the reference command has no parameters, so{delay}was left unsubstituted.--prepare/--concludefor a benchmark when the template contains{…}placeholders but the command has no parameters.--referencein the README (extra baseline command, not a benchmark label) and expand--referenceCLI help.Test plan
cargo test --test integration_tests reference_skips_prepare_with_parameter_placeholderscargo clippy -- -D warningsFixes #847