feat: add --discard-outliers to filter runs before statistics (fixes #837)#890
Open
leno23 wants to merge 1 commit into
Open
feat: add --discard-outliers to filter runs before statistics (fixes #837)#890leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Remove timing runs identified as statistical outliers before computing mean, median, standard deviation, and exported results. Warn when more than 5% of runs are discarded. Fixes sharkdp#837 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--discard-outliersto remove statistical outliers from timing runs before computing summary statistics and exported timing data.Motivation
Fixes #837. Useful when background interference causes a few bad runs but the majority of samples look reasonable.
Example
hyperfine --discard-outliers --runs 20 './my-command.sh'If 2 runs are identified as outliers, the summary is recomputed from the remaining 18 runs and the output notes
(2 outliers discarded).Test plan
cargo testfilter_outliers--discard-outliersruns successfully