feat: allow --shell on a per-command basis#895
Open
leno23 wants to merge 1 commit into
Open
Conversation
Support specifying --shell/-S once for all benchmarks or once per command, matching the existing pattern used by --prepare and --output. Each benchmark now gets its own executor and shell calibration when needed. Fixes sharkdp#850 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--shell/-Sto be specified once for all commands or once per benchmark command (including reference), matching the pattern used by--prepareand--output.Fixes #850
Example
Test plan
cargo fmtcargo test(unit + integration)Made with Cursor