Fix Issue #2805 - Resolve Patched False Negatives#2814
Open
MaxwellOldshein wants to merge 2 commits intosherlock-project:masterfrom
Open
Fix Issue #2805 - Resolve Patched False Negatives#2814MaxwellOldshein wants to merge 2 commits intosherlock-project:masterfrom
MaxwellOldshein wants to merge 2 commits intosherlock-project:masterfrom
Conversation
Contributor
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Frosmin
approved these changes
Mar 8, 2026
Contributor
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
palharez
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the false positive issue for the Patched site as stated in: #2805.
From what I can gather, it appears that the URL for the
Patchedwebsite has changed fromhttps://patched.sh/tohttps://patched.to/due to the fact that traffic sent to the first URL is now currently set to redirect to the second URL automatically.Originally, this site was leveraging the less accurate
error_messagedetection method, but it appears as though thestatus_codemethodology can be leveraged to more accurately detect whether or not usernames exist on the site:Known Valid Username Behavior -->
blue:Known Invalid Username Behavior -->
thisisatotallyfakeusername1234:Username Behavior From Issue -->
bapack.newbie:Closes #2805.