fix: Fixed mouse locking interference bug#517
Draft
Benjas333 wants to merge 2 commits intoshinyflvre:mainfrom
Draft
fix: Fixed mouse locking interference bug#517Benjas333 wants to merge 2 commits intoshinyflvre:mainfrom
Benjas333 wants to merge 2 commits intoshinyflvre:mainfrom
Conversation
(not sure they trigger the bug)
Author
|
Oh wait. I think the problem is using MoveWindow.
It's basically a wrapper over SetWindowPos. I'll try to refactor the MoveWindow calls to SetWindowPos, applying the flags to see if the ClipCursor backup is not required at all. |
Author
|
Didn't work. I'll keep the ClipCursor backup. But it's not ready; there's still an edge case with a variation of the bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed mouse locking interference bug #369
There's probably a better solution, but this one works (I tried so many that didn't, and I'm exhausted).
Explanation
Apparently, functions related to modifying the window (like SetWindowPos and MoveWindow) reset the actual ClipCursor to its default value. So this fix saves the ClipCursor value before moving/modifying the window, and then sets the ClipCursor to its previous value.