fix(BuildStrategy): follow shp-output-insecure properly with buildpacks#2238
Open
sgaist wants to merge 1 commit into
Open
Conversation
openshift-ci
Bot
added
kind/bug
pull-request-size
Bot
added
the
size/M
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The current implementation has one flaw: it creates the CNB_INSECURE_REGISTRIES environment variable in all cases which should not happen when `shp-output-insecure` is set to false. Hence move that part under the PARAM_OUTPUT_INSECURE check. Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
sgaist
force-pushed
the
fix/buildpack-buildstrategy-follow-shp-output-insecure-correctly
branch
from
9d517b4 to
943ac31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The current implementation has one flaw: it creates the CNB_INSECURE_REGISTRIES environment variable in all cases which should not happen when
shp-output-insecureis set to false.Hence move that part under the PARAM_OUTPUT_INSECURE check.
Related Issue
Fixes #2237
Type of PR
/kind bug
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes