Dash2 - #993
Open
shocknet-justin wants to merge 33 commits into
Open
Conversation
db interface fix
asst liab pagination +userids
merge master
Member
Author
|
@BugBot review |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
@BugBot review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3477bd3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
New admin-only endpoints expose user balances, operations, and liability data; incorrect auth or handler bugs could leak sensitive financial/user data, though scope is limited to documented Admin auth.
Overview
Bumps the package to 0.0.32 and adds
express-ws(plus@types/express-ws) for WebSocket support on Express—likely to back live admin/dashboard streams alongside existing subscription RPCs.The LightningPub API surface grows with three Admin endpoints (HTTP and Nostr):
GetAssetsAndLiabilitiesV2atPOST /api/admin/assets/liabilities/v2,GetUserOperationsFromAdminatPOST /api/admin/user/operations, andGetUsersAdminInfoatPOST /api/admin/users/info. Client docs are retitled with a LightningPub prefix on the main HTTP/Nostr sections.Assets/liabilities v2 replaces coarse global limits with per-provider filters (
LiquidityProviderFilter,LndProviderFilter) and returns paginated operation lists (LiquidityAssetOperationsPage,LndAssetOperationsPagewithhas_moreand cursors/index offsets) on the V2 provider types.GetUserOperationsgains optionaluser_idon request and response for admin-targeted queries.TrackedOperationadds optionaluser_id. New typesUserAdminInfo,AppUserAdminInfo, and paginatedUsersAdminInfosupport listing users for admin UIs.Autogenerated Go client (
http_client.go,types.go) andclient.mdreflect these RPCs and messages; implementation handlers are not in this diff.Reviewed by Cursor Bugbot for commit 3477bd3. Bugbot is set up for automated code reviews on this repo. Configure here.