Skip to content

Dash2 - #993

Open
shocknet-justin wants to merge 33 commits into
masterfrom
dash2
Open

Dash2#993
shocknet-justin wants to merge 33 commits into
masterfrom
dash2

Conversation

@shocknet-justin

@shocknet-justin shocknet-justin commented Jul 13, 2026

Copy link
Copy Markdown
Member

Note

Medium Risk
New admin-only endpoints expose user balances, operations, and liability data; incorrect auth or handler bugs could leak sensitive financial/user data, though scope is limited to documented Admin auth.

Overview
Bumps the package to 0.0.32 and adds express-ws (plus @types/express-ws) for WebSocket support on Express—likely to back live admin/dashboard streams alongside existing subscription RPCs.

The LightningPub API surface grows with three Admin endpoints (HTTP and Nostr): GetAssetsAndLiabilitiesV2 at POST /api/admin/assets/liabilities/v2, GetUserOperationsFromAdmin at POST /api/admin/user/operations, and GetUsersAdminInfo at POST /api/admin/users/info. Client docs are retitled with a LightningPub prefix on the main HTTP/Nostr sections.

Assets/liabilities v2 replaces coarse global limits with per-provider filters (LiquidityProviderFilter, LndProviderFilter) and returns paginated operation lists (LiquidityAssetOperationsPage, LndAssetOperationsPage with has_more and cursors/index offsets) on the V2 provider types. GetUserOperations gains optional user_id on request and response for admin-targeted queries. TrackedOperation adds optional user_id. New types UserAdminInfo, AppUserAdminInfo, and paginated UsersAdminInfo support listing users for admin UIs.

Autogenerated Go client (http_client.go, types.go) and client.md reflect these RPCs and messages; implementation handlers are not in this diff.

Reviewed by Cursor Bugbot for commit 3477bd3. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/services/main/adminManager.ts
Comment thread src/services/main/adminManager.ts
Comment thread src/services/main/adminManager.ts
Comment thread src/services/main/adminManager.ts
Comment thread src/services/main/adminManager.ts Outdated
Comment thread src/services/main/appUserManager.ts
@shocknet-justin

Copy link
Copy Markdown
Member Author

@BugBot review

Comment thread src/services/main/adminManager.ts Outdated
Comment thread src/services/main/liquidityProvider.ts Outdated
@socket-security

socket-security Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedexpress-ws@​5.0.210010010075100
Added@​types/​express-ws@​3.0.61001008680100

View full report

@shocknet-justin

Copy link
Copy Markdown
Member Author

@BugBot review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3477bd3. Configure here.

Comment thread src/services/main/liquidityProvider.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants