fix: replace svgo-autocrop dep icon-kit - #1293
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Alastair Fraser (alastair-simon)
marked this pull request as ready for review
July 27, 2026 14:22
Fabian Hüske (fabianhueske)
requested review from
Arnold Stoba (arnoldstoba) and
Fabian Hüske (fabianhueske)
July 28, 2026 09:17
Arnold Stoba (arnoldstoba)
approved these changes
Jul 28, 2026
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/create-meteor-extension
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-prettier-config
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
Fabian Hüske (fabianhueske)
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replace the unmaintained svgo-autocrop dependency (and its transitive puppeteer + jimp) with a vendored copy under src/autocrop that rasterises via @resvg/resvg-js.
Why?
svgo-autocrop renders each icon in headless Chrome just to compute a crop box, so puppeteer downloaded a Chromium binary on nearly every install — slow and flaky in CI — and the package is no longer maintained. @resvg/resvg-js is a prebuilt Rust binary (no browser).
How?
Testing?