build(playwright): reduce worker to 3 to increase test stability#2131
build(playwright): reduce worker to 3 to increase test stability#2131spliffone wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Playwright configuration file (playwright.config.ts) to reduce the number of workers from 4 to 3. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
spliffone
force-pushed
the
build/reduce-playwright-worker
branch
from
4d98d32 to
926d1cd
Compare
|
please rebase w/o merge commit. For the change itself, I think 👍 as it doesn't get slower or only a tiny bit. |
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
What about having an ENV var PW_WORKERS and default it to 3?
spliffone
force-pushed
the
build/reduce-playwright-worker
branch
from
b2615ff to
819ce5b
Compare
| -e PLAYWRIGHT_CONTAINER=true \ | ||
| -e PLAYWRIGHT_isvrt=true \ | ||
| -e PLAYWRIGHT_staticTest=$PLAYWRIGHT_staticTest \ | ||
| -e PW_WORKERS=3 \ |
There was a problem hiding this comment.
I think this one makes no sense. No one runs the pw tests without this script.
So just having the default in the config should be sufficient
There was a problem hiding this comment.
like this it doesn't make any sense. It needs to pass the env to the container instead. This way a user could actually set any number, using the default of 4 if nothing is provided
| -e PW_WORKERS=3 \ | |
| -e PW_WORKERS=$PW_WORKERS \ |
spliffone
force-pushed
the
build/reduce-playwright-worker
branch
from
a2838b2 to
84cef00
Compare
3 participants
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: