Skip to content

feat: provide custom builder with esbuild plugins #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spliffone wants to merge 1 commit into
base: main
Choose a base branch
from
+1,106 −215
Open

feat: provide custom builder with esbuild plugins #2175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,6 @@ Thumbs.db

# EsLint cache
.eslintcache

# Angular builder
projects/live-preview/builders/dist
4 changes: 2 additions & 2 deletions angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"prefix": "app",
"architect": {
"build": {
"builder": "@angular-builders/custom-esbuild:application",
"builder": "@siemens/live-preview:application",
"options": {
"plugins": ["projects/live-preview/esbuild-component-loader.mjs"],
"outputPath": {
Expand Down Expand Up @@ -108,7 +108,7 @@
}
},
"serve": {
"builder": "@angular-builders/custom-esbuild:dev-server",
"builder": "@siemens/live-preview:dev-server",
"options": {
"buildTarget": "element-examples:build"
},
Expand Down
4 changes: 2 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ import angularTemplateConfig from '@siemens/eslint-config-angular/template';
import vitest from '@vitest/eslint-plugin';
import tsdocPlugin from 'eslint-plugin-tsdoc';
import eslintPluginHeaders from 'eslint-plugin-headers';
import { defineConfig } from 'eslint/config';
import { defineConfig, globalIgnores } from 'eslint/config';

// mimic CommonJS variables
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);

export const tsConfig = defineConfig({
export const tsConfig = defineConfig(globalIgnores(['**/dist/']), {
extends: [...angularTypescriptConfig],
files: ['**/*.ts'],
languageOptions: {
Expand Down
208 changes: 0 additions & 208 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"docs:serve:generate": "cross-env DOCS_COMPOSER=true DOCS_COMPOSER_GENERATE=true uv run mkdocs serve",
"icon-viewer:build-docs": "ng build icon-viewer --configuration=production",
"icon-viewer:serve": "ng serve icon-viewer",
"live-preview:build": "ng build live-preview && cpy LICENSE.md \"./dist/@siemens/live-preview/\"",
"live-preview:build": "tsc -p projects/live-preview/builders/tsconfig.json && cpy projects/live-preview/builders/src/application/schema.json projects/live-preview/builders/dist/application/ && cpy projects/live-preview/builders/src/dev-server/schema.json projects/live-preview/builders/dist/dev-server/ && ng build live-preview && cpy LICENSE.md \"./dist/@siemens/live-preview/\"",
"prepare": "husky; exit 0",
"prepare-brand": "cpy --flat node_modules/@simpl/brand/assets/favicon/sie-favicon_internet_64px.png docs/_src --rename=favicon.png && cpy --flat node_modules/@simpl/brand/assets/favicon/sie-favicon_internet_64px.png src --rename=favicon.png && cpy --flat node_modules/@simpl/brand/assets/favicon/sie-favicon_internet_64px.png projects/dashboards-demo/src --rename=favicon.png && cpy --flat node_modules/@simpl/brand/assets/favicon/sie-favicon_internet_64px.png projects/dashboards-demo/mfe/src --rename=favicon.png",
"postversion": "npm run format",
Expand Down Expand Up @@ -123,7 +123,6 @@
"tslib": "2.8.1"
},
"devDependencies": {
"@angular-builders/custom-esbuild": "21.0.3",
"@angular-devkit/build-angular": "21.0.5",
"@angular-devkit/core": "21.0.5",
"@angular-devkit/schematics": "21.0.5",
Expand Down
15 changes: 15 additions & 0 deletions projects/live-preview/builders.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"$schema": "./node_modules/@angular-devkit/architect/src/builders-schema.json",
"builders": {
"application": {
"implementation": "./builders/dist/application",
"schema": "./builders/dist/application/schema.json",
"description": "Angular application builder with custom esbuild plugin support"
},
"dev-server": {
"implementation": "./builders/dist/dev-server",
"schema": "./builders/dist/dev-server/schema.json",
"description": "Angular dev-server with custom esbuild plugin support"
}
}
}
Loading
Loading