Skip to content

feat(file-uploader): merge upload texts into single button label#2243

Open
spliffone wants to merge 1 commit into
mainfrom
refactor/uploader-remove-uploadtextfileselect
Open

feat(file-uploader): merge upload texts into single button label#2243
spliffone wants to merge 1 commit into
mainfrom
refactor/uploader-remove-uploadtextfileselect

Conversation

@spliffone

@spliffone spliffone commented Jun 29, 2026

Copy link
Copy Markdown
Member

The uploadTextFileSelect input has been removed. The whole prompt is now rendered as the file-select button text via uploadDropText, avoiding fragile translation concatenation. A migration removes leftover usages.

BREAKING CHANGE: The uploadTextFileSelect input has been removed from SiFileUploaderComponent and SiFileDropzoneComponent.

The full text now lives in uploadDropText, which renders as the button. Remove uploadTextFileSelect and move its content into uploadDropText.

Before:

<si-file-uploader
  uploadDropText="Drop files here or"
  uploadTextFileSelect="click to upload"
/>

After:

<si-file-uploader uploadDropText="Drop files here or click to upload" />

Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@spliffone spliffone requested review from a team as code owners June 29, 2026 05:25
@spliffone spliffone added the enhancement Topics that make the project better label Jun 29, 2026
@spliffone spliffone added this to the 51.0.0 milestone Jun 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the file uploader and dropzone components by removing the 'uploadTextFileSelect' input and combining its functionality into the 'uploadDropText' input. The default text is updated to "Drop files here or click to upload". To support this breaking change, a schematic migration ('migration-v51') has been added to automatically remove 'uploadTextFileSelect' from templates during the update to version 51. I have no additional feedback to provide as the changes are clean, well-tested, and include the necessary migrations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

The `uploadTextFileSelect` input has been removed. The whole prompt is now
rendered as the file-select button text via `uploadDropText`, avoiding
fragile translation concatenation. A migration removes leftover usages.

BREAKING CHANGE: The `uploadTextFileSelect` input has been removed from
`SiFileUploaderComponent` and `SiFileDropzoneComponent`.

The full text now lives in `uploadDropText`, which renders as the button. Remove `uploadTextFileSelect` and move its content into `uploadDropText`.

Before:

```typescript
<si-file-uploader
  uploadDropText="Drop files here or"
  uploadTextFileSelect="click to upload"
/>
```
After:

```typescript
<si-file-uploader uploadDropText="Drop files here or click to upload" />
```
@spliffone spliffone force-pushed the refactor/uploader-remove-uploadtextfileselect branch from 63a1364 to 9de3c00 Compare June 29, 2026 06:12
@spliffone spliffone added the breaking-changes Marks issues and PRs that are breaking the API label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changes Marks issues and PRs that are breaking the API enhancement Topics that make the project better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant