Skip to content

docs(npm): add consistent README to published packages#2246

Draft
spike-rabbit wants to merge 1 commit into
mainfrom
docs/npm-package-readmes
Draft

docs(npm): add consistent README to published packages#2246
spike-rabbit wants to merge 1 commit into
mainfrom
docs/npm-package-readmes

Conversation

@spike-rabbit

@spike-rabbit spike-rabbit commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

Adds a consistent, minimal README.md to every package published to npm. Each one shows the Element icon, the package name as title, and a call to action linking to https://element.siemens.io.

Affected published packages:

  • @siemens/charts-ng
  • @siemens/dashboards-ng
  • @siemens/element-ng
  • @siemens/element-theme
  • @siemens/element-translate-cli
  • @siemens/element-translate-ng
  • @siemens/live-preview
  • @siemens/maps-ng
  • @siemens/native-charts-ng

Build script cleanup

  • lib:build previously copied the repository root README.md over the package-specific one for element-ng; it now copies only LICENSE.md.
  • Removed redundant README.md copy steps from charts:build and maps:build.

ng-packagr already copies each project's own README.md into its dist/@siemens/* output, and the two source-published packages (element-theme, element-translate-cli) include their README automatically via npm packaging.

Verification

  • Clean rebuilds of element-ng, charts-ng, and dashboards-ng confirm the correct per-package README lands in dist, with LICENSE.md still present.
  • npm pack --dry-run confirms README.md is included for the source-published packages.

Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@spike-rabbit spike-rabbit requested review from a team as code owners June 29, 2026 13:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the README files across all sub-projects to a minimal layout that directs users to the central documentation site (element.siemens.io). In addition, the build scripts in package.json have been updated to copy only the LICENSE.md file to the distribution directories, omitting the README.md files. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@spike-rabbit spike-rabbit force-pushed the docs/npm-package-readmes branch 2 times, most recently from d77249d to e0793ee Compare June 29, 2026 13:57

@timowolf timowolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick to markdown syntax as much as possible and also I would not delete the documentation. This is what developers expect when getting into the readme.

@spike-rabbit spike-rabbit force-pushed the docs/npm-package-readmes branch from e0793ee to 73f730e Compare June 29, 2026 14:38
@spike-rabbit spike-rabbit force-pushed the docs/npm-package-readmes branch from 73f730e to fdc81a5 Compare June 29, 2026 14:42
@spike-rabbit spike-rabbit marked this pull request as draft June 29, 2026 14:57
@spike-rabbit

Copy link
Copy Markdown
Member Author

We should have our docs in one place: element.siemens.io. Having this in README files, that are not indexed by mkdocs will exclude them from the search (Not sure if the MCP has those bundled either).

I will clean up the docs first, as I was not aware how many things are currently hidden in README files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants