Add active hand estimation utility#223
Conversation
| ) | ||
|
|
||
| SHORT_CLIP_FRAMES = 50 | ||
|
|
There was a problem hiding this comment.
this utility is very much tailored to mediapipe
one option is to use a generic util like hands_components from generic, to be able to deal with varying formats
another option is estimate_active_hand should first ask if detect_known_pose_format(pose) == "holistic":
| The heuristic compares torso-normalized wrist geometry, hand landmark confidence, distance from the torso, | ||
| and motion. It uses a short/long clip split: short clips use body-relative wrist motion because summed motion is | ||
| still stable there, while longer clips emphasize tracked hand landmarks and avoid duration-sensitive body-motion | ||
| accumulation. |
There was a problem hiding this comment.
so, can we not use the "long" version always?
There was a problem hiding this comment.
The long version ignores body-motion accumulation, which is correct for long fsboard clips but loses short ChicagoFSWild cases where hand landmarks are sparse and body-relative wrist motion is the strongest signal. The short/long split keeps that short-clip motion signal without letting duration-scaled motion dominate long clips.
| @@ -0,0 +1,104 @@ | |||
| import numpy as np | |||
There was a problem hiding this comment.
please also include 5~ pose files in the test assets, and show that they work, and that mirror_horizontal flips handedness correctly.
(to prevent future regressions)
|
Addressed the review notes:
Validation:
Why not use the long version always? The long version ignores body-motion accumulation, which is correct for long fsboard clips but loses short ChicagoFSWild cases where hand landmarks are sparse and body-relative wrist motion is the strongest signal. The short/long split keeps that short-clip motion signal without letting duration-scaled motion dominate long clips. |
Summary
Validation