Fix: Remove workaround for sops issue #884#80
Open
owanio1992 wants to merge 1 commit intosignageos:masterfrom
Open
Fix: Remove workaround for sops issue #884#80owanio1992 wants to merge 1 commit intosignageos:masterfrom
owanio1992 wants to merge 1 commit intosignageos:masterfrom
Conversation
Author
|
can resolve #77 |
owanio1992
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request removes the workaround that was implemented to address issue #884 in the
sopsbinary.The issue has been resolved in a newer version of
sops, making the workaround of forcing the config path to/dev/nullorNULno longer necessary. This change cleans up the codebase and removes the now-redundant code.Changes:
src/extension.tsthat added the--configargument with a null path.This improves compatibility with current
sopsversions and simplifies the execution arguments.reference
sops issue: getsops/sops#884
sops fixed version: https://github.com/getsops/sops/releases/tag/v3.9.0