Skip to content

[Merged by Bors] - Remove wrong duplicated comment#2751

Closed
dapplion wants to merge 1 commit into
sigp:unstablefrom
dapplion:patch-2
Closed

[Merged by Bors] - Remove wrong duplicated comment#2751
dapplion wants to merge 1 commit into
sigp:unstablefrom
dapplion:patch-2

Conversation

@dapplion
Copy link
Copy Markdown
Collaborator

Issue Addressed

Remove wrong duplicated comment. Comment was copied from ban_peer() but doesn't apply to unban_peer()

Copy link
Copy Markdown
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@AgeManning AgeManning changed the base branch from stable to unstable October 29, 2021 00:23
@AgeManning
Copy link
Copy Markdown
Member

Could you merge in the latest unstable, then CI should pass

@paulhauner paulhauner added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Nov 1, 2021
@paulhauner
Copy link
Copy Markdown
Member

I think bors will handle the merge such that CI passes.

bors r+

@bors
Copy link
Copy Markdown

bors Bot commented Nov 30, 2021

👎 Rejected by PR status

@paulhauner paulhauner removed the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Nov 30, 2021
@paulhauner
Copy link
Copy Markdown
Member

I think bors will handle the merge such that CI passes.

bors r+

Oh no, it's failing the target branch check. There's nothing I can do now.

Copy link
Copy Markdown
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

bors r+

@paulhauner paulhauner added the ready-for-merge This PR is ready to merge. label Dec 2, 2021
bors Bot pushed a commit that referenced this pull request Dec 2, 2021
## Issue Addressed

Remove wrong duplicated comment. Comment was copied from ban_peer() but doesn't apply to unban_peer()
@bors
Copy link
Copy Markdown

bors Bot commented Dec 2, 2021

Build failed:

@michaelsproul
Copy link
Copy Markdown
Member

Blocked on #2850

@michaelsproul
Copy link
Copy Markdown
Member

bors retry

bors Bot pushed a commit that referenced this pull request Dec 3, 2021
## Issue Addressed

Remove wrong duplicated comment. Comment was copied from ban_peer() but doesn't apply to unban_peer()
@michaelsproul
Copy link
Copy Markdown
Member

bors retry

bors Bot pushed a commit that referenced this pull request Dec 6, 2021
## Issue Addressed

Remove wrong duplicated comment. Comment was copied from ban_peer() but doesn't apply to unban_peer()
@bors
Copy link
Copy Markdown

bors Bot commented Dec 6, 2021

@bors bors Bot changed the title Remove wrong duplicated comment [Merged by Bors] - Remove wrong duplicated comment Dec 6, 2021
@bors bors Bot closed this Dec 6, 2021
@dapplion dapplion deleted the patch-2 branch January 24, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants