Fix LT-22316 regression: persist hidden column labels#790
Open
jasonleenaylor wants to merge 1 commit intomainfrom
Open
Fix LT-22316 regression: persist hidden column labels#790jasonleenaylor wants to merge 1 commit intomainfrom
jasonleenaylor wants to merge 1 commit intomainfrom
Conversation
The LT-22265 fix auto-added common columns missing from saved settings, but couldn't distinguish "new column" from "deliberately removed column" since only active columns were persisted. This caused Lexeme Form and other common columns to reappear after navigation. - Bump kBrowseViewVersion to 20 - Save hidden column labels as <hidden> elements sorted for S/R - On load, skip auto-adding columns in the hidden list - Bootstrap: when no hidden tracking exists (pre-upgrade), skip all auto-adds to prevent removed columns from reappearing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mark-sil
approved these changes
Mar 31, 2026
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LT-22265 fix auto-added common columns missing from saved settings, but couldn't distinguish "new column" from "deliberately removed column" since only active columns were persisted. This caused Lexeme Form and other common columns to reappear after navigation.
This change is