Skip to content

Do not add chromeOptions to IE capabilities#8

Open
andrejsstepanovs wants to merge 1 commit into
silverstripe:masterfrom
ecoco:master
Open

Do not add chromeOptions to IE capabilities#8
andrejsstepanovs wants to merge 1 commit into
silverstripe:masterfrom
ecoco:master

Conversation

@andrejsstepanovs
Copy link
Copy Markdown

First of all - Thank You for this repo. It is working like a charm and saved my day!

About this PR:

It is not possible to start up IE browser (in browserstack) with current configuration. It complains about chromeOptions key in capabilities.

      Behat\Mink\Exception\DriverException: Could not open connection: Invalid option: chromeOptions for browser: ie in vendor/silverstripe/mink-facebook-web-driver/src/FacebookWebDriver.php:375
      Stack trace:
      #0 vendor/friends-of-behat/mink/src/Session.php(70): SilverStripe\MinkFacebookWebDriver\FacebookWebDriver->start()
      #1 vendor/friends-of-behat/mink/src/Session.php(145): Behat\Mink\Session->start()
      #2 vendor/friends-of-behat/mink-extension/src/Behat/MinkExtension/Context/RawMinkContext.php(131): Behat\Mink\Session->visit()
      #3 vendor/friends-of-behat/mink-extension/src/Behat/MinkExtension/Context/MinkContext.php(49): Behat\MinkExtension\Context\RawMinkContext->visitPath()

Solution:

Just if statement.
First I checked if browser is chrome but then decided to do other way around and just exclude IE for these params because looks like all other browsers (ff, safari, edge) have no problem with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant