Skip to content

Fix compatibility for cblosc2 v3.x#382

Open
erykoff wants to merge 1 commit into
silx-kit:mainfrom
erykoff:maxdimfix
Open

Fix compatibility for cblosc2 v3.x#382
erykoff wants to merge 1 commit into
silx-kit:mainfrom
erykoff:maxdimfix

Conversation

@erykoff
Copy link
Copy Markdown

@erykoff erykoff commented May 11, 2026

This changes from BLOSC2_MAX_DIM which was never supposed to be public to B2ND_MAX_DIM. See Blosc/c-blosc2#769

This changes from BLOSC2_MAX_DIM which was never supposed to be public
to B2ND_MAX_DIM.  See Blosc/c-blosc2#769
Copy link
Copy Markdown
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you update the embedded filter version information here: (v2.0.0) with:

(commit `e4d0f583 <https://github.com/Blosc/HDF5-Blosc2/tree/e4d0f583f39bf1d3e482aa4695b7dc95afb2b9b2>`_)

For reference, this PR corresponds to upstream PR Blosc/HDF5-Blosc2#3

@erykoff
Copy link
Copy Markdown
Author

erykoff commented May 12, 2026

Sorry, I don't exactly know what link I'm supposed to replace with which? E.g, what is the text and what is the target? Thanks.

@t20100
Copy link
Copy Markdown
Member

t20100 commented May 13, 2026

I forgot to mention that we use git subtree to vendor the compression filter code in this project (see https://www.silx.org/doc/hdf5plugin/latest/contribute.html#guidelines-to-add-a-compression-filter).
If you don't mind, I'll take it over.

@erykoff
Copy link
Copy Markdown
Author

erykoff commented May 13, 2026

Please do! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants