silx view: Added test of hdf5 file locking behavior#4599
Open
t20100 wants to merge 2 commits into
Open
Conversation
t20100
commented
May 18, 2026
| def isViewerReady(): | ||
| for w in app.topLevelWidgets(): | ||
| if isinstance(w, qt.QMainWindow) and w.isVisible(): | ||
| print("ready", flush=True) |
Member
Author
There was a problem hiding this comment.
flush=True needed to flush stdout, otherwise it is buffered
|
|
||
|
|
||
| def testSilxViewHdf5FileLockingEnabled(data_h5, silxViewSubprocess): | ||
| """Test that silx view --hdf5-file-locking locks hdf5 files when opening them""" |
Member
Author
There was a problem hiding this comment.
Also test with locking to make sure that the tests are effectively covering the locking issue ;)
t20100
force-pushed
the
add-silx-view-file-locking-test
branch
from
e56d01e to
efd8cd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)PR summary
This PR adds a non-regression test of
silx view's hdf5 file locking behavior.Follow-up of #4595
Closes #4594
AI Disclosure