Skip to content

refactor: tighten pox-locking visibility#7

Open
simone-stacks wants to merge 3 commits into
developfrom
quality/visibility-tightening
Open

refactor: tighten pox-locking visibility#7
simone-stacks wants to merge 3 commits into
developfrom
quality/visibility-tightening

Conversation

@simone-stacks

Copy link
Copy Markdown
Owner

Three pub fns in pox-locking's private modules (pox_lock_increase_v2, pox_lock_extend_v2 in pox_2.rs; pox_lock_v3 in pox_3.rs) have one in-module caller each. Drop pub to silence rustc's unreachable_pub. Since the containing modules are private (mod pox_2;, mod pox_3;), the items are structurally unreachable outside the crate — no API surface change.

Result of a first smoke-test of the quality-agent.

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d6332ee5-0086-417b-b359-5ec4b140f0d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch quality/visibility-tightening

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant